Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed init script change reloading #28

Merged
merged 1 commit into from
Nov 18, 2013
Merged

Conversation

ernoaapa
Copy link

When Chef changes init script, for example add bind_uri, restart
doesn't load the command line arguments. Need to stop and start to
get changes affect.

Demo:

  • Install Docker to empty machine with :bind-uri defined.
  • Docker get started but doesn't listen on given bind-uri.
  • If you run command "restart docker" it still doesn't listen on given bind uri.
  • If you run commands "stop docker" and "start docker" it will start to listen the given bind-uri.

When Chef changes init script, for example add bind_uri, restart
doesn't load the command line arguments. Need to stop and start to
get changes affect.
@ghost ghost assigned bflad Nov 15, 2013
@bflad
Copy link
Contributor

bflad commented Nov 16, 2013

I'll be able to look at this further tomorrow

@bflad
Copy link
Contributor

bflad commented Nov 18, 2013

Okay, yeah, definitely an oddity with Upstart: http://upstart.ubuntu.com/faq.html#reload

I'm going to merge this then refactor slightly to use initctl as a service instead with a notify reload immediately if possible (this will be useful for an future enhancement to optionally add Upstart jobs for containers).

bflad added a commit that referenced this pull request Nov 18, 2013
Fixed init script change reloading
@bflad bflad merged commit d857f8d into sous-chefs:master Nov 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants