Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not used package in service.tmpl #677

Closed
2 tasks
Xuanwo opened this issue Jul 16, 2021 · 2 comments · Fixed by #679
Closed
2 tasks

Remove not used package in service.tmpl #677

Xuanwo opened this issue Jul 16, 2021 · 2 comments · Fixed by #679
Assignees
@RhnSharma
Labels
good first issue Issue template help wanted

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 16, 2021 •
edited
Loading

It looks like we don't need credential.Provider anymore, we can remove the import:

"github.com/beyondstorage/go-storage/v4/pkg/credential"

Steps

  • Remove the import from cmd/definitions/tmpl/service.tmpl
  • make build to trigger generation
@RhnSharma
Copy link
Contributor

I would like to take this one.

@RhnSharma RhnSharma mentioned this issue Jul 16, 2021
Merged
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jul 16, 2021

I would like to take this one.

Great, I've assigned this issue to you and look forward to your PR!

This was referenced Jul 16, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RhnSharma RhnSharma

Labels
good first issue Issue template help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: Remove not used package in service.tmpl RhnSharma/go-storage
2 participants
@Xuanwo @RhnSharma