Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for GSP-139: Split Specs #627

Closed
6 of 8 tasks
Xuanwo opened this issue Jul 9, 2021 · 2 comments
Closed
6 of 8 tasks

Tracking issue for GSP-139: Split Specs #627

Xuanwo opened this issue Jul 9, 2021 · 2 comments
Assignees

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 9, 2021

Steps

  • docs: Move rfcs and spec here as required in GSP-139 #628
  • Migrate existing PRs to go-storage (after this change, specs will not accept new proposals anymore)
  • Move all issues into go-storage
    • They will be assigned a new number just like we create new issues in go-storage
  • cmd: Move definitions here as described in GSP-139 #652
  • Convert specs into archived (read-only)
  • Remove specs teams in community (we don't need this team anymore)
  • Update links to definitions in site and docs (GSP will not changed, so we don't need to update links to GSP)
  • Update all services to reflect codegen changes
@Xuanwo Xuanwo self-assigned this Jul 9, 2021
@xxchan
Copy link
Contributor

xxchan commented Jul 12, 2021

types in service.toml should be changed to golang types directly?

left -> right

var typeMap = map[string]string{
	// ...

	// Golang self-defined types.
	"context":             "context.Context",
	"http_client_options": "*httpclient.Options",

	// Compose types
	"any":                 "interface{}",
	"byte_array":          "[]byte",
	"string_array":        "[]string",
	"string_string_map":   "map[string]string",
	"time":                "time.Time",
	"BlockIterator":       "*BlockIterator",
	"DefaultServicePairs": "DefaultServicePairs",
	"DefaultStoragePairs": "DefaultStoragePairs",
	"ServiceFeatures":     "ServiceFeatures",
	"StorageFeatures":     "StorageFeatures",
	"ListMode":            "ListMode",
	"Interceptor":         "Interceptor",
	"IoCallback":          "func([]byte)",
	"Object":              "*Object",
	"ObjectMode":          "ObjectMode",
	"ObjectIterator":      "*ObjectIterator",
	"Pairs":               "...Pair",
	"Part":                "*Part",
	"Parts":               "[]*Part",
	"PartIterator":        "*PartIterator",
	"Reader":              "io.Reader",
	"Storager":            "Storager",
	"StoragerIterator":    "*StoragerIterator",
	"StorageMeta":         "*StorageMeta",
	"Writer":              "io.Writer",
}

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jul 12, 2021

Ooops, yes, we need to update all services.

@Xuanwo Xuanwo closed this as completed Sep 1, 2021
@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Sep 15, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 📦 Done in Xuanwo's Work Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants