Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test fails with Dropbox v2 api error too_many_write_operations #893

Closed
JinnyYi opened this issue Oct 8, 2021 · 7 comments
Closed
Assignees

Comments

@JinnyYi
Copy link
Contributor

JinnyYi commented Oct 8, 2021

ref: https://teamcity.beyondstorage.io/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=878&_focus=237

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 8, 2021

Maybe we should follow the Retry-After header before we send next request.

@JinnyYi
Copy link
Contributor Author

JinnyYi commented Oct 8, 2021

Maybe we should follow the Retry-After header before we send next request.

Does this mean we need to implement the retry logic internally?

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 8, 2021

Oh, it's indeed a question. Technically, it's better to implement retry logic on the go-storage side. However, we don't have clear ways to do that for now.

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 8, 2021

Maybe we can check ErrRequestThrottled and retry the request in test logic?

@JinnyYi JinnyYi closed this as completed Oct 19, 2021
@Xuanwo Xuanwo reopened this Oct 19, 2021
@beyondstorage beyondstorage deleted a comment from JinnyYi Oct 19, 2021
@Xuanwo Xuanwo transferred this issue from beyondstorage/go-service-dropbox Oct 19, 2021
@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 19, 2021

I will try to figure out this problem.

@Xuanwo Xuanwo moved this to Backlog in BeyondStorage Oct 19, 2021
@Xuanwo Xuanwo moved this from Backlog to In Design in BeyondStorage Oct 19, 2021
@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 19, 2021

Test local could be successful. Let's try to don't run integration tests at the same time.

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 19, 2021

We will support rate limit error in the further.

@Xuanwo Xuanwo closed this as completed Oct 19, 2021
Repository owner moved this from In Design to Done in BeyondStorage Oct 19, 2021
@Xuanwo Xuanwo self-assigned this Oct 19, 2021
@Xuanwo Xuanwo moved this to 📋 Backlog in Xuanwo's Work Sep 15, 2022
@Xuanwo Xuanwo moved this from 📋 Backlog to 📦 Done in Xuanwo's Work Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants