Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derive Clone/Copy/Debug trio for shape::Cylinder #9705

Merged
merged 1 commit into from
Sep 5, 2023
Merged

derive Clone/Copy/Debug trio for shape::Cylinder #9705

merged 1 commit into from
Sep 5, 2023

Conversation

kamirr
Copy link
Contributor

@kamirr kamirr commented Sep 5, 2023

Objective

I needed to copy a cylinder. Can be done with other shapes already.

Solution

Add proper #[derive(..)] attribute,

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

alice-i-cecile
alice-i-cecile approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL the shapes are all Copy. I'm not sure I agree with that choice, but this PR is fine and correct for consistency reasons :)

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Rendering Drawing game state to the screen A-Math Fundamental domain-agnostic mathematical operations S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 5, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 5, 2023
Merged via the queue into bevyengine:main with commit d04e4bb Sep 5, 2023
26 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@kamirr
derive Clone/Copy/Debug trio for shape::Cylinder (bevyengine#9705)
b58e4d7 
# Objective

I needed to copy a cylinder. Can be done with other shapes already.

## Solution

Add proper `#[derive(..)]` attribute,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamirr @alice-i-cecile