Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Window::set_cursor_position #9456

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix Window::set_cursor_position #9456

merged 1 commit into from
Aug 17, 2023

Conversation

tguichaoua
Copy link
Contributor

Objective

Fixes #9455

This change has probably been forgotten in #8306.

Solution

Remove the inversion of the Y axis when propagates window change back to winit.

@github-actions
Copy link
Contributor

Example alien_cake_addict failed to run, please try running it locally and check the result.

@tguichaoua tguichaoua changed the title fix #9455 Fix Window::set_cursor_position Aug 16, 2023
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Input Player input via keyboard, mouse, gamepad, and more A-Windowing Platform-agnostic interface layer to run your app in O-Windows Specific to the Windows desktop operating system and removed O-Windows Specific to the Windows desktop operating system labels Aug 16, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 16, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 17, 2023
Merged via the queue into bevyengine:main with commit 9473726 Aug 17, 2023
@tguichaoua tguichaoua deleted the fix_9455 branch August 17, 2023 20:59
@cart cart added this to the 0.11.2 milestone Aug 18, 2023
cart pushed a commit that referenced this pull request Aug 18, 2023
@tguichaoua @cart
Fix Window::set_cursor_position (#9456)
12c6fa7 
# Objective

Fixes #9455

This change has probably been forgotten in
#8306.

## Solution

Remove the inversion of the Y axis when propagates window change back to
winit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodentry inodentry inodentry approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.

Setting cursor position while moving the mouse flips the cursor's Y coordinate
5 participants
@tguichaoua @alice-i-cecile @tim-blackbird @inodentry @cart