Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removal_detection example #945

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Add removal_detection example #945

merged 2 commits into from
Nov 30, 2020

Conversation

lukors
Copy link
Contributor

@lukors lukors commented Nov 29, 2020

This PR adds an example that shows how you can know when a component has been removed, so you can react to it.

Related to #941

@lukors lukors marked this pull request as ready for review November 29, 2020 00:20
Copy link
Contributor

@ambeeeeee ambeeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, only issue is where in the changelog you placed the change.

CHANGELOG.md Outdated Show resolved Hide resolved
@lukors
Copy link
Contributor Author

lukors commented Nov 29, 2020

Ah, thanks!

I didn't see the headings because there were no newlines before them, so my markdown syntax highlighting didn't highlight them.

I added newlines before and after the headings in the changelog for the upcoming version so it matches the changelogs for the previous versions.

And I moved the change to Added. :)

@Moxinilian Moxinilian added A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples labels Nov 29, 2020
@cart
Copy link
Member

cart commented Nov 30, 2020

Well done! The comments are clear and helpfully walk the user through each step.

@cart cart merged commit d9c428e into bevyengine:master Nov 30, 2020
@lukors lukors deleted the removal_detection-example branch December 19, 2020 21:42
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants