Add last_changed_tick and added_tick to ComponentTicks #8803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EntityRef::get_change_ticks mentions that ComponentTicks is useful to create change detection for your own runtime. However, ComponentTicks doesn't even expose enough data to create something that implements DetectChanges. Specifically, we need to be able to extract the last change tick. We add a method to get the last change tick.
nicopap
added
C-Feature
mockersf
reviewed
Jun 10, 2023
mockersf
approved these changes
Jun 10, 2023
nicopap
changed the title
james7132
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
EntityRef::get_change_ticks mentions that ComponentTicks is useful to create change detection for your own runtime.
However, ComponentTicks doesn't even expose enough data to create something that implements DetectChanges. Specifically, we need to be able to extract the last change tick.
Solution
We add a method to get the last change tick. We also add a method to get the added tick.
Changelog
last_changed_tickandadded_ticktoComponentTicks