Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement SystemParam for WorldId #7741

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Implement SystemParam for WorldId #7741

wants to merge 3 commits into from

Conversation

LiamGallagher737
Copy link
Member

Objective

Fixes #7736

Solution

Implement the SystemParam trait for WorldId

Changelog

  • WorldId can now be taken as a system parameter and will return the id of the world the system is running in

@james7132 james7132 added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 18, 2023
@james7132 james7132 requested a review from BoxyUwU February 18, 2023 21:23
BoxyUwU
BoxyUwU suggested changes Feb 18, 2023
View reviewed changes
crates/bevy_ecs/src/world/identifier.rs Outdated Show resolved Hide resolved
@james7132 james7132 requested a review from BoxyUwU February 18, 2023 21:37
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 18, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 19, 2023
@LiamGallagher737
Implement SystemParam for WorldId (#7741)
64b0f19 
# Objective

Fixes #7736

## Solution

Implement the `SystemParam` trait for `WorldId`

## Changelog

- `WorldId` can now be taken as a system parameter and will return the id of the world the system is running in
@bors
Copy link
Contributor

bors bot commented Feb 19, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement SystemParam for WorldId [Merged by Bors] - Implement SystemParam for WorldId Feb 19, 2023
@bors bors bot closed this Feb 19, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 20, 2023
@LiamGallagher737 @myreprise1
Implement SystemParam for WorldId (bevyengine#7741)
1926b00 
# Objective

Fixes bevyengine#7736

## Solution

Implement the `SystemParam` trait for `WorldId`

## Changelog

- `WorldId` can now be taken as a system parameter and will return the id of the world the system is running in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make WorldId a SystemParam
4 participants
@LiamGallagher737 @alice-i-cecile @james7132 @BoxyUwU