[Merged by Bors] - Enable deriving Reflect on structs with generic types #7364

cBournhonesque · 2023-01-25T17:41:39Z

Objective

I recently had an issue, where I have a struct:

struct Property {
   inner: T
}

that I use as a wrapper for internal purposes.
I don't want to update my struct definition to

struct Property<T: Reflect>{
   inner: T
}

because I still want to be able to build Property<T> for types T that are not Reflect. (and also because I don't want to update my whole code base with <T: Reflect> bounds)

I still wanted to have reflection on it (for bevy_inspector_egui), but adding derive(Reflect) fails with the error:
T cannot be sent between threads safely. T needs to implement Sync.

I believe that bevy_reflect should adopt the model of other derives in the case of generics, which is to add the Reflect implementation only if the generics also implement Reflect. (That is the behaviour of other macros such as derive(Clone) or derive(Debug).

It's also the current behavior of derive(FromReflect).

Basically doing something like:

impl<T> Reflect for Foo<T>
where T: Reflect

Solution

I updated the derive macros for Structs and TupleStructs to add extra where bounds.
- Every type that is reflected will need a T: Reflect bound
- Ignored types will need a T: 'static + Send + Sync bound. Here's the reason. For cases like this:

#[derive(Reflect)]
struct Foo<T, U>{
   a: T
   #[reflect(ignore)]
   b: U
}

I had to add the bound 'static + Send + Sync to ignored generics like U.
The reason is that we want Foo<T, U> to be Reflect: 'static + Send + Sync, so Foo<T, U> must be able to implement those auto-traits. Foo<T, U> will only implement those auto-traits if every generic type implements them, including ignored types.
This means that the previously compile-fail case now compiles:

#[derive(Reflect)]
struct Foo<'a> {
    #[reflect(ignore)]
    value: &'a str,
}

But Foo<'a> will only be useable in the cases where 'a: 'static and panic if we don't have 'a: 'static, which is what we want (nice bonus from this PR ;) )

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

Added

Possibility to add derive(Reflect) to structs and enums that contain generic types, like so:

#[derive(Reflect)]
struct Foo<T>{
   a: T
}

Reflection will only be available if the generic type T also implements Reflect.
(previously, this would just return a compiler error)

…eric types

crates/bevy_reflect/bevy_reflect_derive/src/registration.rs

crates/bevy_reflect/bevy_reflect_derive/src/impls/structs.rs

MrGVSV · 2023-01-25T18:42:05Z

I didn't implement this for Enums, because enums seem to have a slightly different code structure and it would have been a bigger change. Maybe it can be added in a different PR?

It shouldn't be too difficult to add an active_types method on ReflectEnum and/or EnumVariant. Doing so should make the implementation of this PR work more-or-less like the other impls.

MrGVSV

I think now that we have bevy_reflect_compile_fail_tests, we should add tests to it for PRs like this to ensure that which should fail to compile continues to fail and that which should compile continues to compile.

If there's not a failure case to test, then this comment can be ignored.

cBournhonesque · 2023-01-25T22:41:18Z

@MrGVSV I made some changes:

wrote a utility function for where_clause
made sure tests pass even for ignored reflected types. This has some nice unintended consequences (see explanation in #Solution)
Removed the need to derive Typed at all
added a compile-fail test, for cases where the generic type doesn't implement Reflect.

There are just 2 things I am not sure about:

I wasn't able to get it working for Enums. I didn't really understand how to get a type from an EnumVariant.
I didn't add any bound for ReflectRef::Value or ReflectMeta because I don't understand what that is

crates/bevy_reflect/bevy_reflect_derive/src/registration.rs

crates/bevy_reflect/bevy_reflect_derive/src/utility.rs

crates/bevy_reflect/bevy_reflect_derive/src/derive_data.rs

cBournhonesque · 2023-01-26T06:16:51Z

Sorry I realize now that my PR was a bit hasty and lacked polishing. Thank you for the excellent comments, I agree with everything!

MrGVSV · 2023-01-26T07:39:41Z

Sorry I realize now that my PR was a bit hasty and lacked polishing. Thank you for the excellent comments, I agree with everything!

No worries! It doesn't have to be "polished" haha just as long as you’re receptive to review/discussion— which you are 😄

If anything, I should be apologizing for all my nitpicks because I realize I may have gone a bit overboard in some cases haha

alice-i-cecile

Well-motivated, good analysis of the behavior, solid doc strings and a decent set of compile tests. LGTM!

…-reflect

MrGVSV

Awesome! Just a couple super small fixes and I think we'll be good to go!

crates/bevy_reflect/bevy_reflect_derive/src/derive_data.rs

crates/bevy_reflect/bevy_reflect_derive/src/impls/enums.rs

MrGVSV · 2023-01-27T19:55:24Z

crates/bevy_reflect/bevy_reflect_derive/src/derive_data.rs

@@ -2,12 +2,13 @@ use crate::container_attributes::ReflectTraits;
 use crate::field_attributes::{parse_field_attrs, ReflectFieldAttr};
 use crate::utility::members_to_serialization_denylist;
 use bit_set::BitSet;
+use proc_macro2::TokenStream;


Can we remove this import and just fully qualify the usages in code? It mainly helps to differentiate between proc_macro::TokenStream and proc_macro2::TokenStream without having to check the imports.

We may revisit and decide this practice is not really needed, but just to help keep things consistent for now, we should change it.

We can; but in general I think the common practice is to use proc_macro2::TokenStream everywhere (since it's the one that is compatible with syn and quote) and only at the very last stage convert into a proc_macro::TokenStream.

See for example: https://github.com/serde-rs/serde/tree/master/serde_derive/src

I think most crates have this model; where proc_macro::TokenStream is the only one that is explicitly spelled out and not imported (and is normally only used in lib.rs when the final macro is put together)

Basically, I think that use proc_macro2::TokenStream should be used everywhere by default (since it's the one we apply ops on), and then we just call proc_macro::TokenStream when needed. But this can be left to another PR, ot unblock this one

Yeah I agree, it makes more sense to flip it. But just for consistency until a cleanup PR comes along to handle it, we should try to keep it consistent

crates/bevy_reflect/bevy_reflect_derive/src/impls/typed.rs

crates/bevy_reflect/bevy_reflect_derive/src/registration.rs

crates/bevy_reflect/bevy_reflect_derive/src/utility.rs

alice-i-cecile · 2023-01-27T21:13:00Z

bors try

bors · 2023-01-27T21:28:18Z

try

Build succeeded:

MrGVSV

Awesome job! Thanks for making all those changes. LGTM!

alice-i-cecile · 2023-01-28T00:11:49Z

bors r+

# Objective I recently had an issue, where I have a struct: ``` struct Property { inner: T } ``` that I use as a wrapper for internal purposes. I don't want to update my struct definition to ``` struct Property<T: Reflect>{ inner: T } ``` because I still want to be able to build `Property<T>` for types `T` that are not `Reflect`. (and also because I don't want to update my whole code base with `<T: Reflect>` bounds) I still wanted to have reflection on it (for `bevy_inspector_egui`), but adding `derive(Reflect)` fails with the error: `T cannot be sent between threads safely. T needs to implement Sync.` I believe that `bevy_reflect` should adopt the model of other derives in the case of generics, which is to add the `Reflect` implementation only if the generics also implement `Reflect`. (That is the behaviour of other macros such as `derive(Clone)` or `derive(Debug)`. It's also the current behavior of `derive(FromReflect)`. Basically doing something like: ``` impl<T> Reflect for Foo<T> where T: Reflect ``` ## Solution - I updated the derive macros for `Structs` and `TupleStructs` to add extra `where` bounds. - Every type that is reflected will need a `T: Reflect` bound - Ignored types will need a `T: 'static + Send + Sync` bound. Here's the reason. For cases like this: ``` #[derive(Reflect)] struct Foo<T, U>{ a: T #[reflect(ignore)] b: U } ``` I had to add the bound `'static + Send + Sync` to ignored generics like `U`. The reason is that we want `Foo<T, U>` to be `Reflect: 'static + Send + Sync`, so `Foo<T, U>` must be able to implement those auto-traits. `Foo<T, U>` will only implement those auto-traits if every generic type implements them, including ignored types. This means that the previously compile-fail case now compiles: ``` #[derive(Reflect)] struct Foo<'a> { #[reflect(ignore)] value: &'a str, } ``` But `Foo<'a>` will only be useable in the cases where `'a: 'static` and panic if we don't have `'a: 'static`, which is what we want (nice bonus from this PR ;) ) --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. ### Added Possibility to add `derive(Reflect)` to structs and enums that contain generic types, like so: ``` #[derive(Reflect)] struct Foo<T>{ a: T } ``` Reflection will only be available if the generic type T also implements `Reflect`. (previously, this would just return a compiler error)

bors · 2023-01-28T00:28:15Z

Pull request successfully merged into main.

Build succeeded:

# Objective I recently had an issue, where I have a struct: ``` struct Property { inner: T } ``` that I use as a wrapper for internal purposes. I don't want to update my struct definition to ``` struct Property<T: Reflect>{ inner: T } ``` because I still want to be able to build `Property<T>` for types `T` that are not `Reflect`. (and also because I don't want to update my whole code base with `<T: Reflect>` bounds) I still wanted to have reflection on it (for `bevy_inspector_egui`), but adding `derive(Reflect)` fails with the error: `T cannot be sent between threads safely. T needs to implement Sync.` I believe that `bevy_reflect` should adopt the model of other derives in the case of generics, which is to add the `Reflect` implementation only if the generics also implement `Reflect`. (That is the behaviour of other macros such as `derive(Clone)` or `derive(Debug)`. It's also the current behavior of `derive(FromReflect)`. Basically doing something like: ``` impl<T> Reflect for Foo<T> where T: Reflect ``` ## Solution - I updated the derive macros for `Structs` and `TupleStructs` to add extra `where` bounds. - Every type that is reflected will need a `T: Reflect` bound - Ignored types will need a `T: 'static + Send + Sync` bound. Here's the reason. For cases like this: ``` #[derive(Reflect)] struct Foo<T, U>{ a: T #[reflect(ignore)] b: U } ``` I had to add the bound `'static + Send + Sync` to ignored generics like `U`. The reason is that we want `Foo<T, U>` to be `Reflect: 'static + Send + Sync`, so `Foo<T, U>` must be able to implement those auto-traits. `Foo<T, U>` will only implement those auto-traits if every generic type implements them, including ignored types. This means that the previously compile-fail case now compiles: ``` #[derive(Reflect)] struct Foo<'a> { #[reflect(ignore)] value: &'a str, } ``` But `Foo<'a>` will only be useable in the cases where `'a: 'static` and panic if we don't have `'a: 'static`, which is what we want (nice bonus from this PR ;) ) --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section. ### Added Possibility to add `derive(Reflect)` to structs and enums that contain generic types, like so: ``` #[derive(Reflect)] struct Foo<T>{ a: T } ``` Reflection will only be available if the generic type T also implements `Reflect`. (previously, this would just return a compiler error)

@cart

## How This Works For the Bevy 0.10 release blog post (and for the first time ever), I'm publicly opening the doors to other people writing blog post sections. Specifically, if you worked on a feature in a substantial way and are interested in presenting it, you can now ask to claim a section by leaving a comment in this PR. If you claim a section, submit a pull request to the `release-0.10.0` branch in this repo. For the next week, we will be filling in sections (the release target is Saturday March 4th). Please don't claim a section if you don't plan on completing it within that timeline. Also don't claim a section if you weren't an active participant in the design and implementation of the change (unless you are a Maintainer or SME). I will claim any unclaimed sections. Try to match the style of previous release blog posts as much as possible. 1. Show, don't tell. Don't bombard people with information. Avoid large walls of text _and_ large walls of code. Prefer the pattern "byte sized description of one thing" -> "example code/picture/video contextualizing that one thing" -> repeat. Take readers on a journey step by simple step. 2. Don't use up reader's "mental bandwidth" without good reason. We can't afford page-long descriptions of minor bug fixes. If it isn't a "headliner change", keep the description short and sweet. If a change is self describing, let it do that (ex: We now support this new mesh shape primitive ... this is what it looks like). If it is a "headliner change", still try to keep it reasonable. We always have a lot to cover. 3. In slight competition with point (2), don't omit interesting technical information when it is truly fun and engaging. A good chunk of our users are highly technical and enjoy learning how the sausage is made. Try to strike a balance between "terse and simple" and "nerdy details". 4. When relevant, briefly describe the problem being solved first, then describe the solution we chose. This contextualizes the change and gives the feature value and purpose. 5. When possible, provide visuals. They create interest / keep people hooked / break up the monotony. 6. Record images and videos at the default bevy resolution (1280x720) 7. Provide an accurate listing of authors that meaningfully contributed to the feature. Try to sort in order of "contribution scale". This is hard to define, but try to be fair. When in doubt, ask other contributors, SMEs, and/or maintainers. 8. Provide numbers and graphs where possible. If something is faster, use numbers to back it up. We don't (yet) have automated graph generation in blog post style, so send data / info to me (@cart) if you want a graph made. ## Headliners Headliners are our "big ticket high importance / high profile" changes. They are listed briefly at the beginning of the blog post, their entries are roughly sorted "to the top", and they are given priority when it comes to "space in the blog post". If you think we missed something (or didn't prioritize something appropriately), let us know. * ECS Schedule v3 (previously known as "stageless") * Partial Android Support * Depth and Normal Prepass * Environment Map Lighting * Cascaded Shadow Maps * Distance and Atmospheric Fog * Smooth Skeletal Animation Transitions * Enable Parallel Pipelined Rendering * Windows as Entities * Renderer Optimizations * ECS Optimizations ## Sections These are the sections we will cover in the blog post. If a section has been claimed, it will have `(claimed by X)` in the title. If it is unclaimed it will have `(unclaimed)` in the title. Let us know if we missed a section. We don't cover every feature, but we should cover pretty much everything that would be interesting to users. Note that what is interesting or challenging to implement is not necessarily something that is relevant to our blog post readers. And sometimes the reverse is true! If you believe a section should be split up or reorganized, just bring it up here and we can discuss it. ### ~~Schedule V3 (claimed by @alice-i-cecile)~~ * [Migrate engine to Schedule v3][7267] * [Add `bevy_ecs::schedule_v3` module][6587] * [Stageless: fix unapplied systems][7446] * [Stageless: move final apply outside of spawned executor][7445] * Sets * Base Sets * [Base Sets][7466] * Reporting * [Report sets][7756] * [beter cycle reporting][7463] * Run Conditions * [Add condition negation][7559] * [And/Or][7605] * [Add more common run conditions][7579] * States * [States derive macro][7535] * System Piping Flexibility * [Support piping exclusive systems][7023] * [Allow piping run conditions][7547] ### ~~Depth and Normal Prepass (claimed by @IceSentry)~~ * [Add depth and normal prepass][6284] * [Move prepass functions to prepass_utils][7354] ### ~~Distance and Atmospheric Fog (claimed by @coreh)~~ * [Add Distance and Atmospheric Fog support][6412] ### ~~Cascaded Shadow Maps (claimed by @cart)~~ * [Cascaded shadow maps.][7064] * [Better cascades config defaults + builder, tweak example configs][7456] ### ~~Environment Map Lighting (claimed by @cart)~~ * [EnvironmentMapLight, BRDF Improvements][7051] * [Webgl2 support][7737] ### ~~Tonemapping options (claimed by @cart)~~ * [Initial tonemapping options][7594] ### ~~Android support + unification (claimed by @mockersf)~~ * [IOS, Android... same thing][7493] ### ~~Windows as Entities (claimed by @Aceeri)~~ * [Windows as Entities][5589] * [break feedback loop when moving cursor][7298] * [Fix `Window` feedback loop between the OS and Bevy][7517] ### ~~Enable Parallel Pipelined Rendering (claimed by @james7132)~~ * [Pipelined Rendering][6503] * [Stageless: add a method to scope to always run a task on the scope thread][7415] * [Separate Extract from Sub App Schedule][7046] ### ~~Smooth Skeletal Animation Transitions (claimed by @james7132)~~ * [Smooth Transition between Animations][6922] ### ~~Spatial Audio (claimed by @harudagondi)~~ * [Spatial Audio][6028] ### ~~Shader Processor Features (claimed by @cart)~~ * [Shader defs can now have a value][5900] * [Shaders can now have #else ifdef chains][7431] * [Define shader defs in shader][7518] ### ~~Shader Flexibility Improvements (claimed by @cart)~~ * [add ambient lighting hook][5428] * [Refactor Globals and View structs into separate shaders][7512] ### ~~Renderer Optimizations (claimed by @james7132)~~ * [bevy_pbr: Avoid copying structs and using registers in shaders][7069] * [Flatten render commands][6885] * [Replace UUID based IDs with a atomic-counted ones][6988] * [improve compile time by type-erasing wgpu structs][5950] * [Shrink DrawFunctionId][6944] * [Shrink ComputedVisibility][6305] * [Reduce branching in TrackedRenderPass][7053] * [Make PipelineCache internally mutable.][7205] * [Improve `Color::hex` performance][6940] * [Support recording multiple CommandBuffers in RenderContext][7248] * [Parallelized transform propagation][4775] * [Introduce detailed_trace macro, use in TrackedRenderPass][7639] * [Optimize color computation in prepare_uinodes][7311] * [Directly extract joints into SkinnedMeshJoints][6833] * [Parallelize forward kinematics animation systems][6785] * [Move system_commands spans into apply_buffers][6900] * [Reduce the use of atomics in the render phase][7084] ### ~~ECS Optimizations (claimed by @james7132 )~~ * [Remove redundant table and sparse set component IDs from Archetype][4927] * [Immutable sparse sets for metadata storage][4928] * [Replace BlobVec's swap_scratch with a swap_nonoverlapping][4853] * [Use T::Storage::STORAGE_TYPE to optimize out unused branches][6800] * [Remove unnecessary branching from bundle insertion][6902] * [Split Component Ticks][6547] * [use bevy_utils::HashMap for better performance. TypeId is predefined …][7642] * [Extend EntityLocation with TableId and TableRow][6681] * [Basic adaptive batching for parallel quer- [Speed up `CommandQueue` by storing commands more densely][6391]y iteration][4777] ### ~~Reflect Improvements (claimed by @cart)~~ * [bevy_reflect: Add `ReflectFromReflect` (v2)][6245] * [Add reflection support for VecDeque][6831] * [reflect: add `insert` and `remove` methods to `List`][7063] * [Add `remove` method to `Map` reflection trait.][6564] * [bevy_reflect: Fix binary deserialization not working for unit structs][6722] * [Add `TypeRegistrationDeserializer` and remove `BorrowedStr`][7094] * [bevy_reflect: Add simple enum support to reflection paths][6560] * [Enable deriving Reflect on structs with generic types][7364] * [bevy_reflect: Support tuple reflection paths][7324] * [bevy_reflect: Pre-parsed paths][7321] * [bevy_ecs: ReflectComponentFns without World][7206] ### ~~AsBindGroup Improvements (claimed by @cart)~~ * [Support storage buffers in derive `AsBindGroup`][6129] * [Support raw buffers in AsBindGroup][7701] ### ~~Cylinder Shape (claimed by @cart)~~ * [Add cylinder shape][6809] ### ~~Subdividable Plane Shape (claimed by @cart)~~ * [added subdivisions to shape::Plane][7546] ### ~~StandardMaterial Blend Modes (claimed by @coreh)~~ * [Standard Material Blend Modes][6644] ### ~~Configurable Visibility Component (claimed by @cart)~~ * [enum `Visibility` component][6320] ### Task Improvements (claimed by @cart) * [Fix panicking on another scope][6524] * [Add thread create/destroy callbacks to TaskPool][6561] * [Thread executor for running tasks on specific threads.][7087] * [await tasks to cancel][6696] * [Stageless: move MainThreadExecutor to schedule_v3][7444] * [Stageless: close the finish channel so executor doesn't deadlock][7448] ### ~~Upgrade to wgpu 0.15 (claimed by @cart)~~ * [Wgpu 0.15][7356] ### ~~Expose Bindless / Non-uniform Indexing Support (claimed by @cart)~~ * [Request WGPU Capabilities for Non-uniform Indexing][6995] ### ~~Cubic Spline (claimed by @aevyrie)~~ * [Bezier][7653] ### ~~Revamp Bloom (claimed by @JMS55)~~ * [Revamp bloom](bevyengine/bevy#6677) ### ~~Use Prepass Shaders for Shadows (claimed by @superdump)~~ * [use prepass shaders for shadows](bevyengine/bevy#7784) ### ~~AccessKit (claimed by @alice-i-cecile)~~ * [accesskit](bevyengine/bevy#6874) ### ~~Camera Output Modes (claimed by @cart)~~ * [camera output modes](bevyengine/bevy#7671) ### ~~SystemParam Improvements (claimed by @JoJoJet)~~ * [Make the `SystemParam` derive macro more flexible][6694] * [Add a `SystemParam` primitive for deferred mutations; allow `#[derive]`ing more types of SystemParam][6817] ### ~~Gamepad Improvements (claimed by @cart)~~ * [Gamepad events refactor][6965] * [add `Axis::devices` to get all the input devices][5400] ### ~~Input Methods (claimed by @cart)~~ * [add Input Method Editor support][7325] ### ~~Color Improvements (claimed by @cart)~~ * [Add LCH(ab) color space to `bevy_render::color::Color`][7483] * [Add a more familiar hex color entry][7060] ### ~~Split Up CorePlugin (claimed by @cart)~~ * [Break `CorePlugin` into `TaskPoolPlugin`, `TypeRegistrationPlugin`, `FrameCountPlugin`.][7083] ### ~~ExtractComponent Derive (claimed by @cart)~~ * [Extract component derive][7399] ### ~~Added OpenGL and DX11 Backends By Default (claimed by @cart)~~ * [add OpenGL and DX11 backends][7481] ### ~~UnsafeWorldCell (claimed by @BoxyUwU)~~ * [Move all logic to `UnsafeWorldCell`][7381] * [Rename `UnsafeWorldCellEntityRef` to `UnsafeEntityCell`][7568] ### ~~Entity Commands (claimed by @cart)~~ * [Add a trait for commands that run for a given `Entity`][7015] * [Add an extension trait to `EntityCommands` to update hierarchy while preserving `GlobalTransform`][7024] * [Add ReplaceChildren and ClearChildren EntityCommands][6035] ### ~~Iterate EntityRef (claimed by @james7132)~~ * [Allow iterating over with EntityRef over the entire World][6843] ### ~~Ref Queries (@JoJoJet)~~ * [Added Ref to allow immutable access with change detection][7097] ### ~~Taffy Upgrade (claimed by @cart)~~ * [Upgrade to Taffy 0.2][6743] ### ~~Relative Cursor Position (claimed by @cart)~~ * [Relative cursor position][7199] ### ~~Const UI Config (claimed by @cart)~~ * [Add const to methods and const defaults to bevy_ui][5542] ### ~~Examples (claimed by @cart)~~ * [Add pixelated Bevy to assets and an example][6408] * [Organized scene_viewer into plugins for reuse and organization][6936] ### ~~CI Improvements (claimed by @cart)~~ * [add rust-version for MSRV and CI job to check][6852] * [msrv: only send a message on failure during the actual msrv part][7532] * [Make CI friendlier][7398] * [Fix CI welcome message][7428] * [add an action to ask for a migration guide when one is missing][7507] ### ~~SMEs (@cart)~~ This was already covered in another blog post. Just briefly call out what they are and that this is the first release that used them. Link to the other blog post. * [Subject Matter Experts and new Bevy Org docs][7185] [4775]: bevyengine/bevy#4775 [4777]: bevyengine/bevy#4777 [4853]: bevyengine/bevy#4853 [4927]: bevyengine/bevy#4927 [4928]: bevyengine/bevy#4928 [5400]: bevyengine/bevy#5400 [5428]: bevyengine/bevy#5428 [5542]: bevyengine/bevy#5542 [5589]: bevyengine/bevy#5589 [5900]: bevyengine/bevy#5900 [5950]: bevyengine/bevy#5950 [6028]: bevyengine/bevy#6028 [6035]: bevyengine/bevy#6035 [6129]: bevyengine/bevy#6129 [6179]: bevyengine/bevy#6179 [6245]: bevyengine/bevy#6245 [6284]: bevyengine/bevy#6284 [6305]: bevyengine/bevy#6305 [6320]: bevyengine/bevy#6320 [6391]: bevyengine/bevy#6391 [6408]: bevyengine/bevy#6408 [6412]: bevyengine/bevy#6412 [6503]: bevyengine/bevy#6503 [6524]: bevyengine/bevy#6524 [6547]: bevyengine/bevy#6547 [6557]: bevyengine/bevy#6557 [6560]: bevyengine/bevy#6560 [6561]: bevyengine/bevy#6561 [6564]: bevyengine/bevy#6564 [6587]: bevyengine/bevy#6587 [6644]: bevyengine/bevy#6644 [6649]: bevyengine/bevy#6649 [6681]: bevyengine/bevy#6681 [6694]: bevyengine/bevy#6694 [6696]: bevyengine/bevy#6696 [6722]: bevyengine/bevy#6722 [6743]: bevyengine/bevy#6743 [6785]: bevyengine/bevy#6785 [6800]: bevyengine/bevy#6800 [6802]: bevyengine/bevy#6802 [6809]: bevyengine/bevy#6809 [6817]: bevyengine/bevy#6817 [6831]: bevyengine/bevy#6831 [6833]: bevyengine/bevy#6833 [6843]: bevyengine/bevy#6843 [6852]: bevyengine/bevy#6852 [6885]: bevyengine/bevy#6885 [6900]: bevyengine/bevy#6900 [6902]: bevyengine/bevy#6902 [6922]: bevyengine/bevy#6922 [6926]: bevyengine/bevy#6926 [6936]: bevyengine/bevy#6936 [6940]: bevyengine/bevy#6940 [6944]: bevyengine/bevy#6944 [6965]: bevyengine/bevy#6965 [6988]: bevyengine/bevy#6988 [6995]: bevyengine/bevy#6995 [7015]: bevyengine/bevy#7015 [7023]: bevyengine/bevy#7023 [7024]: bevyengine/bevy#7024 [7046]: bevyengine/bevy#7046 [7051]: bevyengine/bevy#7051 [7053]: bevyengine/bevy#7053 [7060]: bevyengine/bevy#7060 [7063]: bevyengine/bevy#7063 [7064]: bevyengine/bevy#7064 [7069]: bevyengine/bevy#7069 [7083]: bevyengine/bevy#7083 [7084]: bevyengine/bevy#7084 [7087]: bevyengine/bevy#7087 [7094]: bevyengine/bevy#7094 [7097]: bevyengine/bevy#7097 [7185]: bevyengine/bevy#7185 [7199]: bevyengine/bevy#7199 [7205]: bevyengine/bevy#7205 [7206]: bevyengine/bevy#7206 [7248]: bevyengine/bevy#7248 [7267]: bevyengine/bevy#7267 [7298]: bevyengine/bevy#7298 [7311]: bevyengine/bevy#7311 [7321]: bevyengine/bevy#7321 [7324]: bevyengine/bevy#7324 [7325]: bevyengine/bevy#7325 [7354]: bevyengine/bevy#7354 [7356]: bevyengine/bevy#7356 [7364]: bevyengine/bevy#7364 [7381]: bevyengine/bevy#7381 [7398]: bevyengine/bevy#7398 [7399]: bevyengine/bevy#7399 [7415]: bevyengine/bevy#7415 [7428]: bevyengine/bevy#7428 [7431]: bevyengine/bevy#7431 [7444]: bevyengine/bevy#7444 [7445]: bevyengine/bevy#7445 [7446]: bevyengine/bevy#7446 [7448]: bevyengine/bevy#7448 [7456]: bevyengine/bevy#7456 [7463]: bevyengine/bevy#7463 [7466]: bevyengine/bevy#7466 [7481]: bevyengine/bevy#7481 [7483]: bevyengine/bevy#7483 [7493]: bevyengine/bevy#7493 [7507]: bevyengine/bevy#7507 [7510]: bevyengine/bevy#7510 [7512]: bevyengine/bevy#7512 [7517]: bevyengine/bevy#7517 [7518]: bevyengine/bevy#7518 [7532]: bevyengine/bevy#7532 [7535]: bevyengine/bevy#7535 [7546]: bevyengine/bevy#7546 [7547]: bevyengine/bevy#7547 [7559]: bevyengine/bevy#7559 [7568]: bevyengine/bevy#7568 [7579]: bevyengine/bevy#7579 [7594]: bevyengine/bevy#7594 [7605]: bevyengine/bevy#7605 [7639]: bevyengine/bevy#7639 [7642]: bevyengine/bevy#7642 [7653]: bevyengine/bevy#7653 [7701]: bevyengine/bevy#7701 [7737]: bevyengine/bevy#7737 [7756]: bevyengine/bevy#7756 Co-authored-by: François <[email protected]> Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: Boxy <[email protected]> Co-authored-by: IceSentry <[email protected]> Co-authored-by: JoJoJet <[email protected]> Co-authored-by: Aevyrie <[email protected]> Co-authored-by: James Liu <[email protected]> Co-authored-by: Marco Buono <[email protected]> Co-authored-by: Aceeri <[email protected]>

add Reflect and Typed bounds when reflecting on a struct that has gen…

1e3ecec

…eric types

cBournhonesque force-pushed the cb/add-bound-derive-reflect branch from 6de15fb to 1e3ecec Compare January 25, 2023 17:42

MrGVSV self-requested a review January 25, 2023 17:55

MrGVSV added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Jan 25, 2023

apply rustfmt

b52b07a

MrGVSV reviewed Jan 25, 2023

View reviewed changes

crates/bevy_reflect/bevy_reflect_derive/src/registration.rs Outdated Show resolved Hide resolved

crates/bevy_reflect/bevy_reflect_derive/src/registration.rs Outdated Show resolved Hide resolved

crates/bevy_reflect/bevy_reflect_derive/src/impls/structs.rs Outdated Show resolved Hide resolved

MrGVSV suggested changes Jan 25, 2023

View reviewed changes

cbournhonesque-sc added 2 commits January 25, 2023 17:29

create where_clause utility function, handle ignored generics

76c1c93

nit

d59789b

cBournhonesque marked this pull request as ready for review January 25, 2023 22:43

MrGVSV reviewed Jan 26, 2023

View reviewed changes

cbournhonesque-sc added 2 commits January 26, 2023 20:09

address comments

b88b04f

fix clippy

e50062b

alice-i-cecile approved these changes Jan 27, 2023

View reviewed changes

alice-i-cecile added this to the 0.10 milestone Jan 27, 2023

cbournhonesque-sc added 3 commits January 26, 2023 20:34

remove de-duplication

b7c0c8b

fix doc

a953884

Merge remote-tracking branch 'upstream/main' into cb/add-bound-derive…

2a68dbd

…-reflect

alice-i-cecile requested review from MrGVSV and PROMETHIA-27 January 27, 2023 18:16

MrGVSV suggested changes Jan 27, 2023

View reviewed changes

address comments

e71b472

bors bot added a commit that referenced this pull request Jan 27, 2023

Try #7364:

898e1b5

alice-i-cecile requested a review from MrGVSV January 27, 2023 22:16

MrGVSV approved these changes Jan 27, 2023

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 28, 2023

bors bot changed the title ~~Enable deriving Reflect on structs with generic types~~ [Merged by Bors] - Enable deriving Reflect on structs with generic types Jan 28, 2023

bors bot closed this Jan 28, 2023

cart mentioned this pull request Feb 24, 2023

[Merged by Bors] - News: Release 0.10.0 bevyengine/bevy-website#546

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Enable deriving Reflect on structs with generic types #7364

[Merged by Bors] - Enable deriving Reflect on structs with generic types #7364

cBournhonesque commented Jan 25, 2023 •

edited

Loading

MrGVSV commented Jan 25, 2023

MrGVSV left a comment

cBournhonesque commented Jan 25, 2023 •

edited

Loading

cBournhonesque commented Jan 26, 2023

MrGVSV commented Jan 26, 2023

alice-i-cecile left a comment

MrGVSV left a comment

MrGVSV Jan 27, 2023

cBournhonesque Jan 27, 2023 •

edited

Loading

cBournhonesque Jan 27, 2023

MrGVSV Jan 27, 2023

alice-i-cecile commented Jan 27, 2023

bors bot commented Jan 27, 2023

MrGVSV left a comment

alice-i-cecile commented Jan 28, 2023

bors bot commented Jan 28, 2023

[Merged by Bors] - Enable deriving Reflect on structs with generic types #7364

[Merged by Bors] - Enable deriving Reflect on structs with generic types #7364

Conversation

cBournhonesque commented Jan 25, 2023 • edited Loading

Objective

Solution

Changelog

Added

MrGVSV commented Jan 25, 2023

MrGVSV left a comment

Choose a reason for hiding this comment

cBournhonesque commented Jan 25, 2023 • edited Loading

cBournhonesque commented Jan 26, 2023

MrGVSV commented Jan 26, 2023

alice-i-cecile left a comment

Choose a reason for hiding this comment

MrGVSV left a comment

Choose a reason for hiding this comment

MrGVSV Jan 27, 2023

Choose a reason for hiding this comment

cBournhonesque Jan 27, 2023 • edited Loading

Choose a reason for hiding this comment

cBournhonesque Jan 27, 2023

Choose a reason for hiding this comment

MrGVSV Jan 27, 2023

Choose a reason for hiding this comment

alice-i-cecile commented Jan 27, 2023

bors bot commented Jan 27, 2023

try

MrGVSV left a comment

Choose a reason for hiding this comment

alice-i-cecile commented Jan 28, 2023

bors bot commented Jan 28, 2023

cBournhonesque commented Jan 25, 2023 •

edited

Loading

cBournhonesque commented Jan 25, 2023 •

edited

Loading

cBournhonesque Jan 27, 2023 •

edited

Loading