[Merged by Bors] - Make Query fields private
#7149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoxyUwU
added
A-ECS
|
bors try |
mockersf
approved these changes
Jan 10, 2023
tim-blackbird
approved these changes
Jan 10, 2023
BoxyUwU
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Jan 10, 2023
bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
`Query`'s fields being `pub(crate)` means that the struct can be constructed via safe code from anywhere in `bevy_ecs` . This is Not Good since it is intended that all construction of this type goes through `Query::new` which is an `unsafe fn` letting various `Query` methods rely on those invariants holding even though they can be trivially bypassed. This has no user facing impact
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
`Query`'s fields being `pub(crate)` means that the struct can be constructed via safe code from anywhere in `bevy_ecs` . This is Not Good since it is intended that all construction of this type goes through `Query::new` which is an `unsafe fn` letting various `Query` methods rely on those invariants holding even though they can be trivially bypassed. This has no user facing impact
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
|
I think you need to rebase? |
|
no it just tried to merge it with another PR that has been r+'d at the same time |
|
now that #7150 has been merged, you need to rebase this PR. The test query_validates_world_id creates a query but without the field you added in this PR |
BoxyUwU
force-pushed
the
private_query_fields
branch
from
6369a58 to
27cd8e9
Compare
|
this is what i get for adding a test </3 |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
`Query`'s fields being `pub(crate)` means that the struct can be constructed via safe code from anywhere in `bevy_ecs` . This is Not Good since it is intended that all construction of this type goes through `Query::new` which is an `unsafe fn` letting various `Query` methods rely on those invariants holding even though they can be trivially bypassed. This has no user facing impact
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
`Query`'s fields being `pub(crate)` means that the struct can be constructed via safe code from anywhere in `bevy_ecs` . This is Not Good since it is intended that all construction of this type goes through `Query::new` which is an `unsafe fn` letting various `Query` methods rely on those invariants holding even though they can be trivially bypassed. This has no user facing impact
bors
bot
changed the title
Query fields privateQuery fields private
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
`Query`'s fields being `pub(crate)` means that the struct can be constructed via safe code from anywhere in `bevy_ecs` . This is Not Good since it is intended that all construction of this type goes through `Query::new` which is an `unsafe fn` letting various `Query` methods rely on those invariants holding even though they can be trivially bypassed. This has no user facing impact
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
`Query`'s fields being `pub(crate)` means that the struct can be constructed via safe code from anywhere in `bevy_ecs` . This is Not Good since it is intended that all construction of this type goes through `Query::new` which is an `unsafe fn` letting various `Query` methods rely on those invariants holding even though they can be trivially bypassed. This has no user facing impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query's fields beingpub(crate)means that the struct can be constructed via safe code from anywhere inbevy_ecs. This is Not Good since it is intended that all construction of this type goes throughQuery::newwhich is anunsafe fnletting variousQuerymethods rely on those invariants holding even though they can be trivially bypassed.This has no user facing impact