Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add support for Rgb9e5Ufloat textures #6781

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add support for Rgb9e5Ufloat textures #6781

wants to merge 1 commit into from

Conversation

DGriffin91
Copy link
Contributor

@DGriffin91 DGriffin91 commented Nov 28, 2022 •
edited
Loading

Objective

  • Support textures in Rgb9e5Ufloat format.

Solution

  • Add TextureFormatPixelInfo for Rgb9e5Ufloat.

Tested this with a Rgb9e5Ufloat encoded KTX2 texture.

@cart cart added this to the 0.9.1 milestone Nov 28, 2022
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 28, 2022
@alice-i-cecile
Copy link
Member

Merging as trivial: I trust your testing here.

bors r+

bors bot pushed a commit that referenced this pull request Nov 28, 2022
@DGriffin91
Add support for Rgb9e5Ufloat textures (#6781)
63ab5ad 
# Objective

- Support textures in `Rgb9e5Ufloat` format.

## Solution

- Add `TextureFormatPixelInfo` for `Rgb9e5Ufloat`.

Tested this with a `Rgb9e5Ufloat` encoded KTX2 texture.
@bors
Copy link
Contributor

bors bot commented Nov 28, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 28, 2022
@DGriffin91
Add support for Rgb9e5Ufloat textures (#6781)
295faa0 
# Objective

- Support textures in `Rgb9e5Ufloat` format.

## Solution

- Add `TextureFormatPixelInfo` for `Rgb9e5Ufloat`.

Tested this with a `Rgb9e5Ufloat` encoded KTX2 texture.
@bors
Copy link
Contributor

bors bot commented Nov 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add support for Rgb9e5Ufloat textures [Merged by Bors] - Add support for Rgb9e5Ufloat textures Nov 28, 2022
@bors bors bot closed this Nov 28, 2022
cart pushed a commit that referenced this pull request Nov 30, 2022
@DGriffin91 @cart
Add support for Rgb9e5Ufloat textures (#6781)
4f17cd9 
# Objective

- Support textures in `Rgb9e5Ufloat` format.

## Solution

- Add `TextureFormatPixelInfo` for `Rgb9e5Ufloat`.

Tested this with a `Rgb9e5Ufloat` encoded KTX2 texture.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DGriffin91 @ItsDoot
Add support for Rgb9e5Ufloat textures (bevyengine#6781)
e27304e 
# Objective

- Support textures in `Rgb9e5Ufloat` format.

## Solution

- Add `TextureFormatPixelInfo` for `Rgb9e5Ufloat`.

Tested this with a `Rgb9e5Ufloat` encoded KTX2 texture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@DGriffin91 @alice-i-cecile @cart