Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - bevy_reflect: Simplify take-or-else-from_reflect operation #6566

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - bevy_reflect: Simplify take-or-else-from_reflect operation #6566

wants to merge 1 commit into from

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Nov 12, 2022 •
edited
Loading

Objective

There are times where we want to simply take an owned dyn Reflect and cast it to a type T.

Currently, this involves doing:

let value = value.take::<T>().unwrap_or_else(|value| {
  T::from_reflect(&*value).unwrap_or_else(|| {
    panic!(
      "expected value of type {} to convert to type {}.",
      value.type_name(),
      std::any::type_name::<T>()
    )
  })
});

This is a common operation that could be easily be simplified.

Solution

Add the FromReflect::take_from_reflect method. This first tries to take the value, calling from_reflect iff that fails.

let value = T::take_from_reflect(value).unwrap_or_else(|value| {
  panic!(
    "expected value of type {} to convert to type {}.",
    value.type_name(),
    std::any::type_name::<T>()
  )
});

Based on suggestion from @soqb on Discord.

Changelog

  • Add FromReflect::take_from_reflect method

@MrGVSV MrGVSV added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Nov 12, 2022
@MrGVSV MrGVSV force-pushed the reflect-take-from-reflect branch from 70422cc to 9427d43 Compare November 12, 2022 19:17
@MrGVSV MrGVSV changed the title bevy_reflect: Simply take-or-else-from_reflect operation bevy_reflect: Simplify take-or-else-from_reflect operation Nov 13, 2022
@MrGVSV MrGVSV force-pushed the reflect-take-from-reflect branch from 9427d43 to 5c7851d Compare December 18, 2022 21:18
alice-i-cecile
alice-i-cecile approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Jan 11, 2023
@MrGVSV
bevy_reflect: Simplify take-or-else-from_reflect operation (#6566)
229d6c6 
# Objective

There are times where we want to simply take an owned `dyn Reflect` and cast it to a type `T`.

Currently, this involves doing:

```rust
let value = value.take::<T>().unwrap_or_else(|value| {
  T::from_reflect(&*value).unwrap_or_else(|| {
    panic!(
      "expected value of type {} to convert to type {}.",
      value.type_name(),
      std::any::type_name::<T>()
    )
  })
});
```

This is a common operation that could be easily be simplified.

## Solution

Add the `FromReflect::take_from_reflect` method. This first tries to `take` the value, calling `from_reflect` iff that fails.

```rust
let value = T::take_from_reflect(value).unwrap_or_else(|value| {
  panic!(
    "expected value of type {} to convert to type {}.",
    value.type_name(),
    std::any::type_name::<T>()
  )
});
```

Based on suggestion from @soqb on [Discord](https://discord.com/channels/691052431525675048/1002362493634629796/1041046880316043374).

---

## Changelog

- Add `FromReflect::take_from_reflect` method
@bors
Copy link
Contributor

bors bot commented Jan 11, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title bevy_reflect: Simplify take-or-else-from_reflect operation [Merged by Bors] - bevy_reflect: Simplify take-or-else-from_reflect operation Jan 11, 2023
@bors bors bot closed this Jan 11, 2023
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@MrGVSV @alradish
bevy_reflect: Simplify take-or-else-from_reflect operation (bevye…
a72ee9a 
…ngine#6566)

# Objective

There are times where we want to simply take an owned `dyn Reflect` and cast it to a type `T`.

Currently, this involves doing:

```rust
let value = value.take::<T>().unwrap_or_else(|value| {
  T::from_reflect(&*value).unwrap_or_else(|| {
    panic!(
      "expected value of type {} to convert to type {}.",
      value.type_name(),
      std::any::type_name::<T>()
    )
  })
});
```

This is a common operation that could be easily be simplified.

## Solution

Add the `FromReflect::take_from_reflect` method. This first tries to `take` the value, calling `from_reflect` iff that fails.

```rust
let value = T::take_from_reflect(value).unwrap_or_else(|value| {
  panic!(
    "expected value of type {} to convert to type {}.",
    value.type_name(),
    std::any::type_name::<T>()
  )
});
```

Based on suggestion from @soqb on [Discord](https://discord.com/channels/691052431525675048/1002362493634629796/1041046880316043374).

---

## Changelog

- Add `FromReflect::take_from_reflect` method
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@MrGVSV @ItsDoot
bevy_reflect: Simplify take-or-else-from_reflect operation (bevye…
687c597 
…ngine#6566)

# Objective

There are times where we want to simply take an owned `dyn Reflect` and cast it to a type `T`.

Currently, this involves doing:

```rust
let value = value.take::<T>().unwrap_or_else(|value| {
  T::from_reflect(&*value).unwrap_or_else(|| {
    panic!(
      "expected value of type {} to convert to type {}.",
      value.type_name(),
      std::any::type_name::<T>()
    )
  })
});
```

This is a common operation that could be easily be simplified.

## Solution

Add the `FromReflect::take_from_reflect` method. This first tries to `take` the value, calling `from_reflect` iff that fails.

```rust
let value = T::take_from_reflect(value).unwrap_or_else(|value| {
  panic!(
    "expected value of type {} to convert to type {}.",
    value.type_name(),
    std::any::type_name::<T>()
  )
});
```

Based on suggestion from @soqb on [Discord](https://discord.com/channels/691052431525675048/1002362493634629796/1041046880316043374).

---

## Changelog

- Add `FromReflect::take_from_reflect` method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piturnah Piturnah Piturnah approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
Reflection
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrGVSV @alice-i-cecile @Piturnah