[Merged by Bors] - make register on TypeRegistry idempotent
#6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
jakobhellermann
added
C-Bug
alice-i-cecile
approved these changes
Nov 5, 2022
TimJentzsch
approved these changes
Nov 5, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
MrGVSV
approved these changes
Nov 5, 2022
tim-blackbird
approved these changes
Nov 5, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
# Objective - adding a new `.register` should not overwrite old type data - separate crates should both be able to register the same type I ran into this while debugging why `register::<Handle<T>>` removed the `ReflectHandle` type data from a prior `register_asset_reflect`. ## Solution - make `register` do nothing if called again for the same type - I also removed some unnecessary duplicate registrations
bors
bot
changed the title
register on TypeRegistry idempotentregister on TypeRegistry idempotent
PROMETHIA-27
approved these changes
Nov 5, 2022
| @@ -87,6 +87,10 @@ impl TypeRegistry { | |||
|
|
|||
| /// Registers the type described by `registration`. | |||
| pub fn add_registration(&mut self, registration: TypeRegistration) { | |||
| if self.registrations.contains_key(®istration.type_id()) { | |||
There was a problem hiding this comment.
I think this should probably more intelligently merge the type data of the registration without overwriting existing data/registrations rather than skipping, but for now I'm fine with this.
There was a problem hiding this comment.
Agreed here, but that can come later.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - adding a new `.register` should not overwrite old type data - separate crates should both be able to register the same type I ran into this while debugging why `register::<Handle<T>>` removed the `ReflectHandle` type data from a prior `register_asset_reflect`. ## Solution - make `register` do nothing if called again for the same type - I also removed some unnecessary duplicate registrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
.registershould not overwrite old type dataI ran into this while debugging why
register::<Handle<T>>removed theReflectHandletype data from a priorregister_asset_reflect.Solution
registerdo nothing if called again for the same type