[Merged by Bors] - fix spot dir nan bug #6167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
approved these changes
Oct 4, 2022
alice-i-cecile
approved these changes
Oct 4, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
VVishion
approved these changes
Oct 5, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
# Objective fix error with pbr shader's spotlight direction calculation when direction.y ~= 0 ## Solution in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
|
Pull request successfully merged into main. Build succeeded: |
xgbwei
pushed a commit
to xgbwei/bevy
that referenced
this pull request
Oct 5, 2022
# Objective fix error with pbr shader's spotlight direction calculation when direction.y ~= 0 ## Solution in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective fix error with pbr shader's spotlight direction calculation when direction.y ~= 0 ## Solution in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective fix error with pbr shader's spotlight direction calculation when direction.y ~= 0 ## Solution in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective fix error with shadow shader's spotlight direction calculation when direction.y ~= 0 fixes bevyengine#7152 ## Solution same as bevyengine#6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective fix error with pbr shader's spotlight direction calculation when direction.y ~= 0 ## Solution in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective fix error with shadow shader's spotlight direction calculation when direction.y ~= 0 fixes bevyengine#7152 ## Solution same as bevyengine#6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
fix error with pbr shader's spotlight direction calculation when direction.y ~= 0
Solution
in pbr_lighting.wgsl, clamp
1-x^2-z^2to>= 0so that we can safelysqrtit