Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use SpatialBundle/TransformBundle in examples #6002

Closed
wants to merge 1 commit into from

Conversation

tim-blackbird
Copy link
Contributor

Does what it do

@mockersf
Copy link
Member

I think I would prefer examples to avoid chaining insert commands on the same entity, as that's currently not a great pattern in Bevy

@tim-blackbird
Copy link
Contributor Author

#2975 just got merged :)
Am I correct in thinking that will solve your issue with this @mockersf?

@mockersf
Copy link
Member

yup, once this PR is update to only issue one command each time 👍

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change labels Sep 24, 2022
@tim-blackbird
Copy link
Contributor Author

This has been rebased on top of the recent changes to spawning/inserting

@rparrett rparrett added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 6, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 10, 2022

Merge conflict.

@alice-i-cecile
Copy link
Member

@devil-ira can you fix up these merge conflicts?

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 13, 2022
Does what it do

Co-authored-by: devil-ira <[email protected]>
@bors bors bot changed the title Use SpatialBundle/TransformBundle in examples [Merged by Bors] - Use SpatialBundle/TransformBundle in examples Oct 13, 2022
@bors bors bot closed this Oct 13, 2022
@tim-blackbird tim-blackbird deleted the use_the_thing branch October 13, 2022 13:32
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants