Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Disabling default features support in bevy_ecs, bevy_reflect and bevy #5993

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Disabling default features support in bevy_ecs, bevy_reflect and bevy #5993

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Sep 15, 2022 •
edited
Loading

Objective

@mockersf
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Sep 15, 2022
@bors
Try #5993:
cfde7f9
@bors
Copy link
Contributor

bors bot commented Sep 15, 2022

try

Build succeeded:

@mockersf
Copy link
Member Author

bors run was to check that config changes were correct
it doesn't add much duration:
Screenshot 2022-09-15 at 19 10 11

@alice-i-cecile alice-i-cecile added the A-Build-System Related to build systems or continuous integration label Oct 4, 2022
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 19, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 24, 2022
@mockersf
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
64a8485 
…#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by #5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
@bors
Copy link
Contributor

bors bot commented Oct 24, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Disabling default features support in bevy_ecs, bevy_reflect and bevy [Merged by Bors] - Disabling default features support in bevy_ecs, bevy_reflect and bevy Oct 24, 2022
@bors bors bot closed this Oct 24, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
ae3dbdc 
…bevyengine#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by bevyengine#5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
@mockersf @Pietrek14
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
4c5bfb3 
…bevyengine#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by bevyengine#5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Disabling default features support in bevy_ecs, bevy_reflect and bevy (…
342be38 
…bevyengine#5993)

# Objective

- Fix disabling features in bevy_ecs (broken by bevyengine#5630)
- Add tests in CI for bevy_ecs, bevy_reflect and bevy as those crates could be use standalone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerSebas MinerSebas MinerSebas left review comments

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mockersf @alice-i-cecile @james7132 @tim-blackbird @MinerSebas