-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add a module for common system chain
/pipe
adapters
#5776
Closed
+131
−3
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4ae6f19
Add a module for common system adapters
JoJoJet f91ac9f
Add `Option`/`Result` conversion adapters
JoJoJet 4b9a5f7
Add the `system_adapter` module to the prelude
JoJoJet 83d5456
Add module-level documentation
JoJoJet baea3d1
Add conversion adapters
JoJoJet da1935b
Add the `parse` adapter
JoJoJet 3c3e050
Add a test to assert that adapters are systems
JoJoJet bddf844
Remove a note
JoJoJet cadd7a7
Apply suggestions from code review
JoJoJet 62ca3a9
Remove trivial adapters
JoJoJet abe715f
Add a fn to convert a regular function to an adapter
JoJoJet 9324272
Remove `ok*` adapters
JoJoJet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a fn to convert a regular function to an adapter
commit abe715f7938a6a98d3ca763da19f37b6a82c7c8c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO
new
may be confusing. In rustnew
is generally used to create an object.Since this is a mapping operation, I think
map
would fit better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I respectfully disagree. The meaning behind the name
system_adapter::new
is "create a new system adapter from some fn", which should be clear enough IMO. And the resulting system adapter is an object, of course.I don't think it makes sense to call it
map
, since the mapping is semantically being done by the.chain()
call.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't take into consideration the mod name. It makes sense.