[Merged by Bors] - fix shader compilation error reporting for non-wgsl shaders #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
A-Rendering
cart
reviewed
Dec 26, 2021
jakobhellermann
force-pushed
the
fix-shader-compile-errors
branch
from
5a1aaf3 to
5f83b76
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 29, 2021
in #3289 I accidentally only logged errors for wgsl shaders, this PR expands the error reporting the the other supported shader types.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
mockersf
pushed a commit
to mockersf/bevy
that referenced
this pull request
Jan 1, 2022
…ne#3441) in bevyengine#3289 I accidentally only logged errors for wgsl shaders, this PR expands the error reporting the the other supported shader types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #3289 I accidentally only logged errors for wgsl shaders, this PR expands the error reporting the the other supported shader types.