Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - make texture from sprite pipeline filterable #3236

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - make texture from sprite pipeline filterable #3236

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 2, 2021

Objective

Solution

  • in sprite_pipeline, make the texture filterable

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 2, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Dec 2, 2021
@cart
Copy link
Member

cart commented Dec 2, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 2, 2021
@mockersf
make texture from sprite pipeline filterable (#3236)
fe8902c 
# Objective

- Fix #3235

## Solution

- in `sprite_pipeline`, make the texture filterable
@bors
Copy link
Contributor

bors bot commented Dec 2, 2021

Build failed:

@cart
Copy link
Member

cart commented Dec 2, 2021

New clippy rules :)

@cart
Copy link
Member

cart commented Dec 2, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 2, 2021
@mockersf
make texture from sprite pipeline filterable (#3236)
4423a2f 
# Objective

- Fix #3235

## Solution

- in `sprite_pipeline`, make the texture filterable
@bors
Copy link
Contributor

bors bot commented Dec 3, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title make texture from sprite pipeline filterable [Merged by Bors] - make texture from sprite pipeline filterable Dec 3, 2021
@bors bors bot closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasEi NiklasEi NiklasEi approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All pipelined examples crash with "non-filterable float texture"
3 participants
@mockersf @cart @NiklasEi