Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix iOS CI #3228

Closed
wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 1, 2021

Objective

Solution

  • Fix indentation in makefile
  • Adds scheme that is now needed

With this, make install works on my m1 Mac but still fails on my intel Mac unless I run something like make install; cargo build --target x86_64-apple-ios; make install; cargo build --target x86_64-apple-ios; make install. It seems something is off when executing cargo through xcodebuild on my setup but not sure what. So this PR will probably not fix iOS CI 😞

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 1, 2021
@mockersf mockersf added A-Build-System Related to build systems or continuous integration O-iOS Specific to the iOS mobile operating system C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Dec 1, 2021
@cart
Copy link
Member

cart commented Dec 1, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 1, 2021
# Objective

- With #3109 I broke iOS CI: https://github.com/bevyengine/bevy/runs/4374891646?check_suite_focus=true

## Solution

- Fix indentation in makefile
- Adds scheme that is now needed

With this, `make install` works on my m1 Mac but still fails on my intel Mac unless I run something like `make install; cargo build --target x86_64-apple-ios; make install; cargo build --target x86_64-apple-ios; make install`. It seems something is off when executing cargo through `xcodebuild` on my setup but not sure what. So this PR will probably not fix iOS CI 😞
@bors bors bot changed the title Fix iOS CI [Merged by Bors] - Fix iOS CI Dec 1, 2021
@bors bors bot closed this Dec 1, 2021
@mockersf
Copy link
Member Author

mockersf commented Dec 2, 2021

it's now failing with

          ld: warning: building for macOS, but linking in .tbd file (/usr/lib/system/libsystem_sim_pthread_host.dylib) built for iOS Simulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples O-iOS Specific to the iOS mobile operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants