[Merged by Bors] - Optional .system(), part 2
#2403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
added
C-Code-Quality
mockersf
approved these changes
Jun 29, 2021
NathanSWard
approved these changes
Jun 29, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
# Objective - Extend work done in #2398. - Make `.system()` syntax optional when using system descriptor API. ## Solution - Slight change to `ParallelSystemDescriptorCoercion` signature and implementors. --- I haven't touched exclusive systems, because it looks like the only two other solutions are going back to doubling our system insertion methods, or starting to lean into stageless. The latter will invalidate the former, so I think exclusive systems should remian pariahs until stageless. I can grep & nuke `.system()` thorughout the codebase now, which might take a while, or we can do that in subsequent PR(s).
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
.system(), part 2.system(), part 2
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2021
# Objective - Continue work of #2398 and #2403. - Make `.system()` syntax optional when using `.config()` API. ## Solution - Introduce new prelude trait, `ConfigurableSystem`, that shorthands `my_system.system().config(...)` as `my_system.config(...)`. - Expand `configure_system_local` test to also cover the new syntax.
Ratysz
added
A-Core
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective - Extend work done in bevyengine#2398. - Make `.system()` syntax optional when using system descriptor API. ## Solution - Slight change to `ParallelSystemDescriptorCoercion` signature and implementors. --- I haven't touched exclusive systems, because it looks like the only two other solutions are going back to doubling our system insertion methods, or starting to lean into stageless. The latter will invalidate the former, so I think exclusive systems should remian pariahs until stageless. I can grep & nuke `.system()` thorughout the codebase now, which might take a while, or we can do that in subsequent PR(s).
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective - Continue work of bevyengine#2398 and bevyengine#2403. - Make `.system()` syntax optional when using `.config()` API. ## Solution - Introduce new prelude trait, `ConfigurableSystem`, that shorthands `my_system.system().config(...)` as `my_system.config(...)`. - Expand `configure_system_local` test to also cover the new syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
.system#2398..system()syntax optional when using system descriptor API.Solution
ParallelSystemDescriptorCoercionsignature and implementors.I haven't touched exclusive systems, because it looks like the only two other solutions are going back to doubling our system insertion methods, or starting to lean into stageless. The latter will invalidate the former, so I think exclusive systems should remian pariahs until stageless.
I can grep & nuke
.system()thorughout the codebase now, which might take a while, or we can do that in subsequent PR(s).