Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cubic prefix to all cubic curve generators #10299

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Add Cubic prefix to all cubic curve generators #10299

merged 2 commits into from
Oct 28, 2023

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented Oct 28, 2023 •
edited
Loading

Objective

Solution

  • Renamed.

Changelog

  • Changed: BSpline -> CubicBSpline
  • Changed: CardinalSpline -> CubicCardinalSpline
  • Changed: Hermite -> CubicHermite

Migration Guide

  • Rename: BSpline -> CubicBSpline
  • Rename: CardinalSpline -> CubicCardinalSpline
  • Rename: Hermite -> CubicHermite

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide A-Math Fundamental domain-agnostic mathematical operations labels Oct 28, 2023
@alice-i-cecile alice-i-cecile added this to the 0.12 milestone Oct 28, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 28, 2023
@mockersf mockersf added this pull request to the merge queue Oct 28, 2023
Merged via the queue into bevyengine:main with commit 9d088dd Oct 28, 2023
22 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@aevyrie @ameknite
Add Cubic prefix to all cubic curve generators (bevyengine#10299)
bd9d0cd 
# Objective

- Fixes bevyengine#10258 

## Solution

- Renamed.

---

## Changelog

- Changed: `BSpline` -> `CubicBSpline`
- Changed: `CardinalSpline` -> `CubicCardinalSpline`
- Changed: `Hermite` -> `CubicHermite`

## Migration Guide

- Rename: `BSpline` -> `CubicBSpline`
- Rename: `CardinalSpline` -> `CubicCardinalSpline`
- Rename: `Hermite` -> `CubicHermite`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@aevyrie
Add Cubic prefix to all cubic curve generators (bevyengine#10299)
94afda0 
# Objective

- Fixes bevyengine#10258 

## Solution

- Renamed.

---

## Changelog

- Changed: `BSpline` -> `CubicBSpline`
- Changed: `CardinalSpline` -> `CubicCardinalSpline`
- Changed: `Hermite` -> `CubicHermite`

## Migration Guide

- Rename: `BSpline` -> `CubicBSpline`
- Rename: `CardinalSpline` -> `CubicCardinalSpline`
- Rename: `Hermite` -> `CubicHermite`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

Finish renaming cubic splines
3 participants
@aevyrie @alice-i-cecile @mockersf