Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make CI less failing on cargo deny bans #10151

Merged
merged 2 commits into from
Oct 16, 2023
Merged

make CI less failing on cargo deny bans #10151

merged 2 commits into from
Oct 16, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 16, 2023 •
edited
Loading

Objective

  • Job cargo deny for bans is failing too often to be useful
  • Having only one version of all dependencies is not realistic

Solution

  • Only warn on multiple dependencies of a crate
  • Deny some specific crates that we know shouldn't be present multiple time

@mockersf mockersf added A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on labels Oct 16, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 16, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 16, 2023
Merged via the queue into bevyengine:main with commit 71329fe Oct 16, 2023
26 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mockersf @ameknite
make CI less failing on cargo deny bans (bevyengine#10151)
23ad15c 
# Objective

- Job cargo deny for bans is failing too often to be useful
- Having only one version of all dependencies is not realistic

## Solution

- Only warn on multiple dependencies of a crate
- Deny some specific crates that we know shouldn't be present multiple
time
@mockersf mockersf mentioned this pull request Dec 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 23, 2023
@mockersf
finish cleaning up dependency bans job (#11059)
eca7924 
# Objective

- After #10151, cache check is less useful in dependency ban job
- It fails anyway because the steps are not in the right order

## Solution

- Remove the added steps
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
make CI less failing on cargo deny bans (bevyengine#10151)
753a721 
# Objective

- Job cargo deny for bans is failing too often to be useful
- Having only one version of all dependencies is not realistic

## Solution

- Only warn on multiple dependencies of a crate
- Deny some specific crates that we know shouldn't be present multiple
time
@mockersf mockersf mentioned this pull request Feb 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @IceSentry