Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename App::add_plugins to App::add_plugin_group #7631

Closed
alice-i-cecile opened this issue Feb 11, 2023 · 4 comments
Closed

Rename App::add_plugins to App::add_plugin_group #7631

alice-i-cecile opened this issue Feb 11, 2023 · 4 comments
Labels
A-App Bevy apps and plugins C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

This method is very easily and subtly typo'd and regularly bites new users.

What solution would you like?

Rename it to add_plugin_group.

Additional context

See #7630 for an example, but I've seen this regularly.
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-App Bevy apps and plugins labels Feb 11, 2023
@CmPons
Copy link

CmPons commented Feb 12, 2023

Hey, I'm not sure if this is a good first issue, but I'm starting to look into this. @alice-i-cecile I have the changes ready, just trying to test it right now.

@alice-i-cecile
Copy link
Member Author

Should be easy to implement! The real trick is convincing everyone that it's a good change :)

@CmPons CmPons mentioned this issue Feb 12, 2023
Closed
@alice-i-cecile alice-i-cecile added the X-Controversial There is active debate or serious implications around merging this PR label Feb 14, 2023
@alice-i-cecile alice-i-cecile mentioned this issue Feb 14, 2023
Open
@alice-i-cecile
Copy link
Member Author

I think we should consider fixing this upstream by improving the diagnostics instead. There's not a clear argument for either API (as called out by Cart in #7643), and this is a Rust wide problem with a confusing / misleading diagnostic.

@geieredgar geieredgar mentioned this issue Feb 15, 2023
Closed
@alice-i-cecile alice-i-cecile mentioned this issue Mar 9, 2023
Closed
@BD103
Copy link
Member

BD103 commented Mar 4, 2024

With add_plugin being deprecated and only add_plugins remaining, I'm going to close this as not planned.

@BD103 BD103 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CmPons @alice-i-cecile @BD103