Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning/prevent calling app .run() in Plugin build method #6145

Closed
ShinySapphic opened this issue Oct 2, 2022 · 1 comment
Closed
Labels
C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled

Comments

@ShinySapphic
Copy link
Contributor

What problem does this solve or what need does it fill?

Accidentally calling .run() in a plugin's build method prevents other plugins from running correctly. This is because .run() Finalizes the [App] configuration. Sometimes one might call this method by mistake and spend hours trying to figure out why most of their app isn't running.

What solution would you like?

Either a warning informing users of an accidental .run() call or an alternative App struct for plugins to use where .run() is not present. The App's .run() method should only be possible to call in the main app configuration as is intended.

What alternative(s) have you considered?

  • Not accidentally calling .run() in a plugin's build method
@ShinySapphic ShinySapphic added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 2, 2022
@bjorn3
Copy link
Contributor

bjorn3 commented Oct 2, 2022

Duplicate of #4231 (open PR: #4241)

@bjorn3 bjorn3 closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled
Projects
None yet
Development

No branches or pull requests

2 participants