Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtrack nightly versions when CI fails on nightly but not stable #5331

Open
alice-i-cecile opened this issue Jul 15, 2022 · 1 comment
Open
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

NIghtly regularly fails for reasons outside of control. Usually, this is because the latest version broke one of our dependencies.

Typically this is fixed pretty quickly (within a day or two) either in Rust or upstream. But until then, we can't merge PRs.

What solution would you like?

When the crate build on stable (but not nightly):

  1. Use the next most recent nightly version.
  2. If this fails again, repeat this several times.
  3. Log a relatively visible warning of this.

Additional context

For an example of the most recent breakage, see #5330, caused by the problem fixed in NotIntMan/inplace_it#11

See this Zulip thread for a discussion with the Rustlang team about possible solutions on both ends.

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Build-System Related to build systems or continuous integration labels Jul 15, 2022
@mockersf
Copy link
Member

mockersf commented Jul 15, 2022

That could be quite hard to do with GitHub actions... and backtracking could be very costly (in time)

I would prefer:

  • run nightly on a cron
  • report status to an external "database" (could be a git repo... preferably another repo to avoid too many commits to this one)
  • in CI, use the last reported nightly

That wouldn't add a lot of complexity to existing CI, but we would need a place to report the status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible
Projects
None yet
Development

No branches or pull requests

2 participants