Allow mocking inputs for Gamepad
#16221
Labels
A-Input
Player input via keyboard, mouse, gamepad, and more
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
P-Regression
Functionality that used to work but no longer does. Add a test for this!
Milestone
Comments
Shatur
added
C-Feature
alice-i-cecile
added
A-Input
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 4, 2024
# Objective Closes #16221. ## Solution - Make `Gamepad` fields public and remove delegates / getters. - Move `impl Into` to `Axis` methods (delegates for `Axis` used `impl Into` to allow passing both `GamepadAxis` and `GamepadButton`). - Improve docs. ## Testing - I run tests. Not sure if the migration guide is needed, since it's a feature from RC, but I wrote it just in case. --- ## Migration Guide - `Gamepad` fields are now public. - Instead of using `Gamepad` delegates like `Gamepad::just_pressed`, call these methods directly on the fields. --------- Co-authored-by: Alice Cecile <[email protected]>
mockersf
pushed a commit
that referenced
this issue
Nov 5, 2024
# Objective Closes #16221. ## Solution - Make `Gamepad` fields public and remove delegates / getters. - Move `impl Into` to `Axis` methods (delegates for `Axis` used `impl Into` to allow passing both `GamepadAxis` and `GamepadButton`). - Improve docs. ## Testing - I run tests. Not sure if the migration guide is needed, since it's a feature from RC, but I wrote it just in case. --- ## Migration Guide - `Gamepad` fields are now public. - Instead of using `Gamepad` delegates like `Gamepad::just_pressed`, call these methods directly on the fields. --------- Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
After #15685 it became inconvenient to mock inputs. On 0.14 we could call
set_pressedorset. But these methods are no longer exposed.It's still possible to do this by sending events, but it's inconsistent with the rest of the input and not very ergonomic.
What solution would you like?
I would like to bring back
set_pressedandset.Additional context
There is a similar issue regardless gamepad creation that predates the gamepads rework: #4911. Could be solved by adding a constructor for
Gamepadcomponent.The text was updated successfully, but these errors were encountered: