Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meshable probably shouldn't require Default #11746

Closed
alice-i-cecile opened this issue Feb 6, 2024 · 1 comment
Closed

Meshable probably shouldn't require Default #11746

alice-i-cecile opened this issue Feb 6, 2024 · 1 comment
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member 

          `Meshable` probably shouldn't require `Default`, but imo the shapes should have (consistent) defaults. It can be useful at least for prototyping, and an editor (like Unity, Godot etc.) would need some defaults for shapes anyway

Originally posted by @Jondolf in #11688 (comment)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations labels Feb 6, 2024
@valenotary valenotary mentioned this issue Feb 7, 2024
Merged
@Jondolf
Copy link
Contributor

Jondolf commented Feb 7, 2024

I think this might've been a misunderstanding, as Meshable already doesn't seem to require Default now that I'm double-checking. So this doesn't seem to be an actual issue and can probably be closed?

(extra context: #11688 (comment))

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @Jondolf