Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Migration guide 0.9 #470

Closed
wants to merge 41 commits into from

Conversation

IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Oct 25, 2022

Migration guide generated by #469

This is mostly just the generated output with a tiny bit of manual modifications.

@rparrett
Copy link
Contributor

rparrett commented Oct 26, 2022

I added C-Breaking-Change to a few PRs that were definitely breaking and had migration guides.

edit: resolved

@rparrett
Copy link
Contributor

rparrett commented Oct 26, 2022

Compiling notes here for additions or changes. Deleting these as I address them. Feel free to pick one up if I haven't done it yet.

### Whole document

Standardize on
// Old (Bevy 0.8)
// New (Bevy 0.9)

Make a second pass at overall order

### 6000
The mouse changes will be reverted before release, so this text needs updating
Needs formatting

### 6345 and 6354 and 5723
Can we create a smaller but just-as-illustrative scene example?
Can we do even better an include an enum and tuple struct?

### 5340
Code block might be more clear for novice rust users or non-english-speakers.

@IceSentry
Copy link
Contributor Author

@rparrett you can suggest changes, as long as it isn't anything too big. When I generate the guide again I make sure to only stage the new guides and keep changes to anything already modified

@ickk
Copy link
Member

ickk commented Oct 27, 2022

I finished a review of every PR in this list looking for breaking changes that weren't already labelled.
https://github.com/bevyengine/bevy/pulls?q=is%3Apr+closed%3A%3E%3D2022-07-31+%22merged+by+bors%22+
Thanks @rparrett for catching a few.

I identified 4 PRs that I didn't make a decision on one way or the other:

Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick skim for now.

content/learn/book/migration-guides/0.8-0.9/_index.md Outdated Show resolved Hide resolved
content/learn/book/migration-guides/0.8-0.9/_index.md Outdated Show resolved Hide resolved
content/learn/book/migration-guides/0.8-0.9/_index.md Outdated Show resolved Hide resolved
content/learn/book/migration-guides/0.8-0.9/_index.md Outdated Show resolved Hide resolved
@rparrett
Copy link
Contributor

rparrett commented Nov 8, 2022

Combined the scene format changes here: IceSentry#6

@laundmo
Copy link
Contributor

laundmo commented Nov 8, 2022

Just a heads up, while applying this guide, I noticed that there isn't any documentation for the reworked PluginGroup Trait usage, especially concering PluginGroupBuilder, yet.

Heres the changes which i needed:

  • change the build signature from fn build(&mut self, group: &mut bevy::app::PluginGroupBuilder) to fn build(self) -> PluginGroupBuilder
  • add let mut group = PluginGroupBuilder::start::<Self>(); at the start
  • change group.add to group = group.add
  • change #[cfg(not(feature = "myfeature"))] to use blocks like
    #[cfg(not(feature = "myfeature"))]
    {
        group = group.add(SomePlugin);
    }

@mockersf
Copy link
Member

mockersf commented Nov 8, 2022

that looks like changes from bevyengine/bevy#6336. the migration guide for this one focused on plugin group user rather than plugin group builder

@cart
Copy link
Member

cart commented Nov 12, 2022

bors r+

@cart
Copy link
Member

cart commented Nov 12, 2022

Great work everyone!

bors bot pushed a commit that referenced this pull request Nov 12, 2022
Migration guide generated by #469 

This is mostly just the generated output with a tiny bit of manual modifications.

Co-authored-by: Charles <[email protected]>
Co-authored-by: Rob Parrett <[email protected]>
@bors
Copy link

bors bot commented Nov 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Migration guide 0.9 [Merged by Bors] - Migration guide 0.9 Nov 12, 2022
@bors bors bot closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.