Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to NPM? #1

Closed
bebraw opened this issue Feb 5, 2014 · 8 comments
Closed

Publish to NPM? #1

bebraw opened this issue Feb 5, 2014 · 8 comments
Assignees

Comments

@bebraw
Copy link

bebraw commented Feb 5, 2014

Hi,

It would be handy if this module was available through NPM. I hope you publish it.

@bettiolo
Copy link
Owner

bettiolo commented Feb 5, 2014

As per your request, I will make a (bundled) NPM package. It will take me a couple of days.

@bettiolo bettiolo self-assigned this Feb 5, 2014
@bettiolo bettiolo added this to the Bundled NPM Package milestone Feb 5, 2014
@bebraw
Copy link
Author

bebraw commented Feb 5, 2014

Ok. FYI, I came by another library, oauth-sign, that seems to do more or less the same as yours.

@bettiolo
Copy link
Owner

bettiolo commented Feb 5, 2014

I think that the main advantage of this project is the extensive test coverage for all the corner cases present in the OAuth specification.

This is the test file: signature.tests.js

@bebraw
Copy link
Author

bebraw commented Feb 5, 2014

I think that the main advantage of this project are the extensive test coverage that cover all the corner cases written in the OAuth specification.

Maybe you could coordinate development with @mikeal somehow? One possibility would be to extract the test suite into a module of its own which both libraries could consume. But I'll leave that for you guys to discuss.

@bettiolo
Copy link
Owner

bettiolo commented Feb 5, 2014

@bebraw That is a good idea. I considered writing tests in Gherkin language so any OAuth signature library can implement them. I never had time to do it.

@bettiolo
Copy link
Owner

Sorry for the delay @bebraw.
I have to do make quite a few changes to the code to make it work nicely on node.js.

  • Change the test runner and assertion library
  • On node use cryptojs and url parser dependencies instead of bundling them
  • Make the same code base works in the browser as well as in node.js

@bebraw
Copy link
Author

bebraw commented Feb 12, 2014

@bettiolo Ok. Note that I managed to resolve my OAuth issues. But if you want to take the library to the next level, by all means. :)

@bettiolo
Copy link
Owner

Published to npm: https://www.npmjs.org/package/oauth-signature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants