Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong vertical metrics causes positioning issues in internet explorer #9

Open
jean343 opened this issue Jun 28, 2018 · 1 comment
Open

Comments

@jean343
Copy link

jean343 commented Jun 28, 2018

Hello,

Thanks for making the lato font as an npm package. There is an issue with the vertical positioning of the font in Internet Explorer, and it could be solved by modifying the .woff file.

The issue can be seen below, even when setting a line-height, the text is not vertically centered.
image

I suggest to convert the woff font which could be done by setting "Auto-Adjust: Vertical Metrics” in fontsquirrel, this fixes the problem in IE, and does not touch the other browsers which are using the woff2 font.

This bug is similar to this bug in Fira: mozilla/Fira#57

Thanks!!

@nishavaitywebdev
Copy link

Thank you so much. This fix works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants