MSP_OSD_CHAR_WRITE triggered on build with DJI and USE_OSD_HD only

[haslinghuis]

Describe the bug

Per title, this triggers a reboot when called in configurator but should not trigger when on HD only build.

To Reproduce

Change alarm settings and MSP_OSD_CHAR_WRITE is triggered.

This does not happen on my Walksnail builds.

Expected behavior

Not to call `MSP_OSD_CHAR_WRITE' which is used for fonts.

Support ID

30dce583-2963-4954-b5ce-4142ae014d19

Flight controller

KAKUTEH7

Other components

DJI Gear: V1 Goggle / Caddx Vista with DJI Cam / both on 01.00.0606 with wtfosd
RX: JETIEXBUS

How are the different components wired up (including port information)

No response

Add any other context about the problem that you think might be relevant here

No response

[ctzsnooze]

Which alarm timer is being changed, and where is the change being made - in configurator, OSD?

[haslinghuis]

Change is made in configurator:

[haslinghuis]

Easy fix would be prohibiting the MSP request in configurator when video mode is HD.

But like to know where it's coming from as I don't have any DJI equipment as it does not happen on Walksnail.

[SteveCEvans]

I just checked this with a default build target of KAKUTEH7 and I'm seeing this issue on DJI, and WS, and indeed with neither connected.

Using the up/down arrows doesn't trigger the issue, but entering a value in the Alarm field for either timer triggers the stream of messages.

Clearly a configurator issue.

Tested with 10.9.0 and 10.8.0 so this has been an issue for some time.

[SteveCEvans]

Using

diff --git a/src/js/tabs/osd.js b/src/js/tabs/osd.js
index 7a56f80..ec84e34 100644
--- a/src/js/tabs/osd.js
+++ b/src/js/tabs/osd.js
@@ -255,6 +255,7 @@ FONT.msp = {
 };
 
 FONT.upload = function($progress) {
+ console.log('FONT.upload');
     return FONT.data.characters
         .reduce(
             (p, x, i) =>
@@ -3429,6 +3430,7 @@ osd.initialize = function(callback) {
             if (!GUI.connect_lock) { // button disabled while flashing is in progress
                 $('a.flash_font').addClass('disabled');
                 $('.progressLabel').text(i18n.getMessage('osdSetupUploadingFont'));
+                         console.log('calling FONT.upload');
                 FONT.upload($('.progress').val(0)).then(function() {
                     $('.progressLabel').text(i18n.getMessage('osdSetupUploadingFontEnd', {length: FONT.data.characters.length}));
                 });

I see:

[haslinghuis]

Thanks @SteveCEvans raised a PR in configurator.

[SteveCEvans]

See betaflight/betaflight-configurator#3790