Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud build feature selection component is buggy #3457

Closed
3 tasks done
GTorreil opened this issue May 19, 2023 · 6 comments · Fixed by #3500
Closed
3 tasks done

cloud build feature selection component is buggy #3457

GTorreil opened this issue May 19, 2023 · 6 comments · Fixed by #3500
Labels

Comments

@GTorreil
Copy link

Describe the bug

I have consistently reproduced buggy behavior from the "tag list" component that handles feature selection for cloud builds.

A video of the problem is availabile here : https://youtu.be/Zmzu7pTbqzc

To Reproduce

As shown in the video, remove some features and add one (in my case , servo).
the feature does not appear but it is selected, some text remains and there's void space in the input.

Expected behavior

An example of expected behavior can be found here :

https://vuetifyjs.com/en/components/autocompletes/#usage

Select :

  • clearable
  • chips
  • multiple

Configurator version

10.9.0

Flight controller configuration

N/A

Add any other context about the problem that you think might be relevant here

No response

@haslinghuis
Copy link
Member

@VitroidFPV please take a look - as this field is buggy indeed.

@VitroidFPV
Copy link
Member

@GTorreil could you please elaborate? Except for the extra margin on the left of where you type the input, I cannot tell much of a difference between the example and the configurator behavior

@haslinghuis
Copy link
Member

Often when I need to add something into Custom Defines mouse was left above - and I'm starting to type into Other Options.
Removing the ability to type in Other Options is probably the solution to this.

@VitroidFPV
Copy link
Member

I'm not sure what to fix, maybe besides the extra margin on the left. Would it be preferential to try to make the text box behave exactly as the example, or make it purely a select box?

@haslinghuis
Copy link
Member

haslinghuis commented May 19, 2023

Agree - would opt for pure select box.

Maybe like the debug mode selection box in blackbox tab

@GTorreil
Copy link
Author

GTorreil commented May 20, 2023

Hello, sorry for the late reply.

UX bugs are very hard to describe, so I hoped my video would help. But I can say for sure that following my STRs lead to behavior that is unexpected and misleading (selected features do not appear, weird text behavior) -- that is, at least, on my machine.

With that said, it is not a major roadblock so the best solution might be the most simple, here are some ideas I can think of :

  • Exchange the "tag-style inputs" for a set of checkboxes
  • Use a list of checkboxes that can be filtered with a filter string

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants