-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input type checkbox component export inner prop as FormCheck instead of HTMLElement #374
Comments
Hi @SimonNegrin , |
Hi! I'm trying to use native controls validation and I need access to the HTMLInputElement validity property. When I use an Input type text there is no problem because the inner prop is exported as HTMLInputElement but this is not de case when the Input is a type checkbox. |
Ah! I see the issue now. When you use Input type="checkbox", this line is incorrect: Line 213 in 9931180
It should be:
Thanks for the find/explanation, we'll fix up today. |
Merged, will release soon |
Ok, thank you!! 🎉🎉 This will ease so much my forms validation. |
Released in 5.6.3 |
@bestguy, shouldnt this issue be closed? |
Yep, thanks, I usually give issue opener chance to confirm & close, but this was left open. |
I supposed this is an error and it should export the subjacent HTMLElement. I've taken a look to the FormCheck component and I think the fix would be change the lines with
bind:this={inner}
bybind:inner
.The text was updated successfully, but these errors were encountered: