Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridlines on selected sheets #222

Open
ThomasHSimm opened this issue May 11, 2023 · 0 comments · Fixed by #228
Open

Gridlines on selected sheets #222

ThomasHSimm opened this issue May 11, 2023 · 0 comments · Fixed by #228
Assignees
Labels
Milestone

Comments

@ThomasHSimm
Copy link

Is your feature request related to a problem? Please describe.
The end user has asked that "Every sheet except cover sheet should have grid lines"

Describe the solution you'd like
A clear and concise description of what you want to happen.
Add gridline number as an option for different sheets, or have as above as default.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Will try xlsxwriter / openpyxl to open file an modify then re-save, if no easy fix within gptables.

Additional context
The gridline option is set in gptables in gptables.core.wrappers.py class GPWorkbook and function add_worksheet:

worksheet._workbook = self # Create reference to wb, for formatting
worksheet.hide_gridlines(2)
return worksheet
https://xlsxwriter.readthedocs.io/page_setup.html

The following values of option are valid for hide_gridlines:

0 = Don’t hide gridlines.

  • 1 = Hide printed gridlines only.
  • 2 = Hide screen and printed gridlines.

Or, if you don’t supply an argument the default option is 1, i.e. only the printed gridlines are hidden.

@rowanhemsi rowanhemsi added the enhancement ✨ New feature or request label Jul 4, 2023
@rowanhemsi rowanhemsi added this to the v1.3.0 milestone Jul 4, 2023
@ldavies99 ldavies99 self-assigned this Jul 11, 2023
@ellie-o ellie-o modified the milestones: v1.3.0, v1.2.0 Jun 27, 2024
@ellie-o ellie-o linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants