Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

209 demo code #233

Merged
merged 12 commits into from
Aug 21, 2024
Merged

209 demo code #233

merged 12 commits into from
Aug 21, 2024

Conversation

ldavies99
Copy link
Collaborator

This branch resolves #209

@ldavies99 ldavies99 self-assigned this Jun 28, 2024
@ldavies99 ldavies99 added the documentation 📖 Improvements or additions to documentation label Jun 28, 2024
@ldavies99 ldavies99 requested a review from danmilne1 June 28, 2024 10:38
@rowanhemsi rowanhemsi linked an issue Jun 28, 2024 that may be closed by this pull request
Create code to demonstrate replication of the ONS good standards example spreadsheet #209
Open
@ldavies99 ldavies99 requested a review from rowanhemsi June 28, 2024 14:18
rowanhemsi
rowanhemsi requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@rowanhemsi rowanhemsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition to the set of examples. Unfortunately when I run it and try to open the spreadsheet, Excel is giving me a warning and says it needs to try to repair the document. Do you know what is causing this?

gptables/examples/survey_data.py Outdated Show resolved Hide resolved
gptables/examples/survey_data.py Outdated Show resolved Hide resolved
@ldavies99 ldavies99 merged commit dc6aaff into dev Aug 21, 2024
13 checks passed
@ldavies99 ldavies99 deleted the 209-demo-code branch August 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanhemsi rowanhemsi rowanhemsi requested changes

@danmilne1 danmilne1 Awaiting requested review from danmilne1

Assignees

@ldavies99 ldavies99

Labels
documentation 📖 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create code to demonstrate replication of the ONS good standards example spreadsheet
2 participants
@ldavies99 @rowanhemsi