Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuff to do! #49

Open
AndreasThinks opened this issue Feb 16, 2022 · 1 comment
Open

Stuff to do! #49

AndreasThinks opened this issue Feb 16, 2022 · 1 comment

Comments

@AndreasThinks
Copy link

All, having been using this for awhile (on windows) I have a few tweaks I'd like to propose:

  1. Add python-dotenv as an optional requirement for those on windows

This just makes using secrets and environment variables much more feasible on windows

  1. Revisiting pre-commit hooks

I find the current hooks are maybe a little too much...Black + Flake8 means you have to do loads of faffing. But I'm happy to be corrected

@AndreasThinks
Copy link
Author

Giving this a bit of a boost, because I've been considering make a fork that removes flake8 (which I find a bit too bossy for my tastes) and potentially adds the nbdev hooks (which should help with git commits) - would be curious for people's thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant