Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy to pre-commit hook for type checking #35

Open
nacnudus opened this issue Jul 6, 2021 · 1 comment
Open

Add mypy to pre-commit hook for type checking #35

nacnudus opened this issue Jul 6, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hooks Related to pre-commit hooks

Comments

@nacnudus
Copy link
Contributor

nacnudus commented Jul 6, 2021

mypy is used for type annotations, and could also be used to statically check them. See the pre-commit code for an example configuration.
@ESKYoung
Copy link
Collaborator

ESKYoung commented Jul 6, 2021

There's also a question on whether this should be enforced strictly (although likely hooks will fail regardless). This can be done with the disallow_untyped_defs = True option.

@ESKYoung ESKYoung mentioned this issue Jul 6, 2021
Open
@ESKYoung ESKYoung added enhancement New feature or request good first issue Good for newcomers hooks Related to pre-commit hooks labels Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hooks Related to pre-commit hooks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nacnudus @ESKYoung