Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom blacklist, that can be configured via flake8 argument and in setup.cfg #4

Open
Melevir opened this issue May 4, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@Melevir
Copy link
Contributor

Melevir commented May 4, 2020

Now blacklists are builtin, they should be configured.

@Melevir Melevir added the enhancement New feature or request label May 4, 2020
@lowitea
Copy link

lowitea commented Oct 1, 2020

Hi!
I have made a PR #8
@Melevir could you please review it :)

@joseguerr
Copy link

joseguerr commented Sep 14, 2021

Hey there,

Is it possible to add an example in your readme file or even in the setup.cfg how to add a custom word to the blacklist?

I have tried to add 'df' and 'result' into in my custom blacklist but so far, with no success. Here are the lines that I have tried to add into my .flake8 config file:
custom_bad_names = df,result
custom-bad-names = df,result
add-bad-varnames = df,result
add_bad_varnames = df,result
variable_names_blacklist = df,result
variable-names-blacklist = df,result
custom_bad_names = {'df', 'result'}
custom-bad-names = {'df', 'result'}
add-bad-varnames = {'df', 'result'}
add_bad_varnames = {'df', 'result'}
variable_names_blacklist = {'df', 'result'}
variable-names-blacklist = {'df', 'result'}

Many thanks!

@lowitea
Copy link

lowitea commented Sep 15, 2021

Hi!
My PR was not merged, I eventually just closed it.

@joseguerr
Copy link

Thanks @lowitea, appreciate your reply. At this point I'm considering to simple make the move to pylint. Do you happen to other flake8 plugin that implements this behaviour?

Strange that no one gave you any sort of feedback on this one..
Cheers

@lowitea
Copy link

lowitea commented Sep 16, 2021

Unfortunately, I do not know of any other plugins. I will try to contact the maintainers of this plugin and rediscover my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants