Update dockerfile #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase on https://github.com/bertsky/ocrd_cis/tree/fix-alpha-shape (because that's the branch currently in ocrd_all, so you would have far fewer commits here)? |
bertsky
requested changes
Feb 12, 2024
This is just a dummy commit to try to trigger circleci
bertsky
reviewed
Feb 13, 2024
…d only relative paths)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of series to offer single ocrd modules as Docker Containers (ocrd slim containers) to be used with ocr-d network.
The Dockerfile works for me when I skip the tests. They don't work because the used resources are no longer available. Maybe that can easily be fixed, but I would leave that for later.
Previously I was not sure if the Dockerfile is up to date and indeed intended for ocrd or maybe for other purposes. That why I just replaced it (with just installing the python stuff like in the other PR) and didn't care to debug.
So thank you for your previous comments.