Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of the driver #2

Closed
stof opened this issue Jan 26, 2015 · 7 comments
Closed

Status of the driver #2

stof opened this issue Jan 26, 2015 · 7 comments

Comments

@stof
Copy link
Contributor

stof commented Jan 26, 2015

Hello,

I'm one of the lead developers of Mink. I would like to know how to consider this driver. Do you plan to maintain it actively ? In yes, we could link to it in the official doc (creating a new section about third-party drivers) once the driver is updated to be compatible with Mink 1.6 (current stable). I can do a full review of the driver in this case, if you want to help you improving it.

@bertrandmoulard
Copy link
Owner

Hi Stof

Yes, I'm planning on maintaining it actively. It's been on hold a bit because I've been waiting for my CTO to respond to an email asking how to open source this thing properly since I spent some company time working on it (I work at Etsy). I'd be happy for it to be considered as an "official" mink driver and I'm happy to help with whatever is needed (making sure the test suite passes for example).

@stof
Copy link
Contributor Author

stof commented Jan 26, 2015

@bertrandmoulard if you continue to maintain it (and if your company agrees about this in case it is coming from work stuff), the repo could even be moved the minkphp organization to become an official driver in the future (it requires passing the Mink 1.6 driver testsuite first).

@bertrandmoulard
Copy link
Owner

Quick update on this. I updated the travis config so QT and capybara-webkit get installed on the build boxes. The tests are all passing locally but most of them are failing on travis. I think it's because those tests rely on a function that start a http server, and maybe travis won't let the tests do that. I'm not sure yet.

@bertrandmoulard
Copy link
Owner

Hi there, the build is now passing in travis ci. What's the next step to become more official?

@bertrandmoulard
Copy link
Owner

Hi Christophe

I put this on hold for a while but I have some time work on it again now.
If I work on making is pass the Mink driver test suite, do you think it has
a future as a official mink driver?

thanks

On Mon, Jan 26, 2015 at 9:07 AM Christophe Coevoet [email protected]
wrote:

@bertrandmoulard https://github.com/bertrandmoulard if you continue to
maintain it (and if your company agrees about this in case it is coming
from work stuff), the repo could even be moved the minkphp organization to
become an official driver in the future (it requires passing the Mink 1.6
driver testsuite first).


Reply to this email directly or view it on GitHub
#2 (comment)
.

@stof
Copy link
Contributor Author

stof commented Apr 27, 2015

If you continue to help maintaining it once it is official, yes.

@bertrandmoulard
Copy link
Owner

Great, then I'll start working on that test suite. I might hit you up for
help along the way if I get stuck.

thanks!

On Mon, Apr 27, 2015 at 1:28 PM Christophe Coevoet [email protected]
wrote:

If you continue to help maintaining it once it is official, yes.


Reply to this email directly or view it on GitHub
#2 (comment)
.

@stof stof closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants