Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration and improve performance #7

Open
TrademarkTM opened this issue Sep 9, 2018 · 2 comments
Open

Add configuration and improve performance #7

TrademarkTM opened this issue Sep 9, 2018 · 2 comments

Comments

@TrademarkTM
Copy link

When editing a map (zooming in and out, moving..) I noticed that the plugin was at 20% in my timings, which is pretty high and unreliable for players to use. Can't it be optimized or 'delayed' in order to avoid high CPU usage?

When not editing, it seems pretty stable, staying at <1% in timings, which is great. Even so, it would be nice to have a update delay option the configuration. 1 tick seems overkill to me.

Amazing plugin btw! 9/10
Keep up the good work. Thanks!

@bergerkiller
Copy link
Member

Yeah this should be doable. The idea of maplands was mostly as a static map wall display, but when players are using it as an overhead map I can imagine it being quite laggy. There is already an iterative form of rendering, which means even the processing done in one tick could be spread out over multiple. I'll see if I can come up with a suitable configuration parameter to change the work done per tick.

@axemwa
Copy link

axemwa commented Jan 25, 2019

I'm also having performance issues with this plugin and I'm using 1.13.2 atm, please fix performance
image
Reference Link - https://www.spigotmc.org/threads/maplands.269054/page-2#post-3292580
Timings report # 2 - https://timings.aikar.co/?id=1a365a7281e14538a0592432847f01c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants