Unused parameter constants in setup.sh?

[CTXz]

I was wondering if there's any purpose for the following constants defined at the top of qemu-pi-setup/setup.sh:

DISK="sd.img"
SIZE=256
SIZEUNIT=M

DISK is not used once throughout the script, neither is SIZEUNIT. SIZE is also technically not used, as it is overwritten by the 2nd parameter of resize_img().

Not sure about DISK, but as for the size related constants, did you perhaps meant to use it as an argument for resize_img() instead of calling it with a fixed size of 2G?

Here's the resize_img() In question, on line 62 of qemu-pi-setup/setup.sh:

resize_img "$IMGNAME" 2G

My assumption would be that the following line was meant to be there instead:

resize_img "$IMGNAME" "$SIZE$SIZEUNIT"

Thanks