Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate: why are we guarding against currentTime changes during track load? #371

Closed
benwiley4000 opened this issue Feb 16, 2019 · 1 comment
Closed

Investigate: why are we guarding against currentTime changes during track load? #371

benwiley4000 opened this issue Feb 16, 2019 · 1 comment

Comments

@benwiley4000
Copy link
Owner

Noticed while reviewing the problem/solution for #370

I can't really figure out why I added this check to enforce currentTime during a track load. Is this even possible?

cassette/packages/core/src/PlayerContextProvider.js

Line 689 in 5f99ee2

// correct currentTime to preset, if applicable, during load

I don't want to just remove it without investigating what's even possible. Looking at the spec or browser implementations might help.
@benwiley4000 benwiley4000 mentioned this issue Feb 24, 2019
Closed
@benwiley4000
Copy link
Owner Author

Closed in #392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benwiley4000