Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility audit/support #261

Closed
benwiley4000 opened this issue Sep 25, 2018 · 4 comments
Closed

Accessibility audit/support #261

benwiley4000 opened this issue Sep 25, 2018 · 4 comments

Comments

@benwiley4000
Copy link
Owner

benwiley4000 commented Sep 25, 2018

We should try to make version 2 as accessible as possible. This means:

  • Support for text tracks (may be somewhat involved to build an API around this)
  • Support for screen readers... can a blind person read the UI easily? (only applicable to the default player implementation). Buttons should ideally have aria-label attributes explaining their function. Note that these should be swappable with other translations ideally.. (think about that for Right to left language support #247).
  • Support for keyboard navigation for all functions - mostly need to make sure it's intuitive to adjust volume and progress via keyboard (only applicable to the default player implementation)

Resource: https://a11yproject.com/

@benwiley4000 benwiley4000 added this to the 2.0 release milestone Sep 25, 2018
@benwiley4000
Copy link
Owner Author

benwiley4000 commented Jan 7, 2019

For text tracks:

Spun back into #108.

For screen readers:

Spun out as #399.

For keyboard navigation:

Again this will require some thought but might be more immediately feasible than text track support. Do we need to look at using a native element like range selector? Probably best to figure this out before we go into beta because it could affect the API for ProgressBar.

Spun out as #395.

@benwiley4000
Copy link
Owner Author

I forgot about #108. If we spin out text track support it can be tracked there.

@benwiley4000
Copy link
Owner Author

benwiley4000 commented Feb 27, 2019

Keyboard navigation added in #396.

@benwiley4000
Copy link
Owner Author

Closing since all tasks are spun out into separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant