Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7 keyword arguments warning #93

Closed
sj26 opened this issue Aug 25, 2020 · 0 comments · Fixed by #98
Closed

Ruby 2.7 keyword arguments warning #93

sj26 opened this issue Aug 25, 2020 · 0 comments · Fixed by #98
Labels
bug Something isn't working

Comments

@sj26
Copy link
Contributor

sj26 commented Aug 25, 2020

I just noticed this error:

good_job-1.2.1/lib/good_job/adapter.rb:11: warning: Passing the keyword argument as the last hash parameter is deprecated
good_job-1.2.1/lib/good_job/configuration.rb:5: warning: The called method `initialize' is defined here

Perhaps this method needs:

ruby2_keywords(:initialize) if respond_to?(:ruby2_keywords, true)

a la:

https://github.com/rails/rails/blob/fbe2433be6e052a1acac63c7faf287c52ed3c5ba/activesupport/lib/active_support/core_ext/object/try.rb#L18

@bensheldon bensheldon added the bug Something isn't working label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants