From 9446165d5b0bfe4238a8569e97ff73f003c2fbcd Mon Sep 17 00:00:00 2001 From: Ben Sheldon Date: Tue, 15 Sep 2020 07:56:51 -0700 Subject: [PATCH] Fix LogSubscriber notifications for finished_timer_task and finished_job_task --- lib/good_job/log_subscriber.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/good_job/log_subscriber.rb b/lib/good_job/log_subscriber.rb index 33c14d83a..ad00c2182 100644 --- a/lib/good_job/log_subscriber.rb +++ b/lib/good_job/log_subscriber.rb @@ -25,8 +25,7 @@ def create(event) end # @macro notification_responder - def timer_task_finished(event) - # FIXME: This method does not match any good_job notifications. + def finished_timer_task(event) exception = event.payload[:error] return unless exception @@ -36,8 +35,7 @@ def timer_task_finished(event) end # @macro notification_responder - def job_finished(event) - # FIXME: This method does not match any good_job notifications. + def finished_job_task(event) exception = event.payload[:error] return unless exception