diff --git a/Gemfile.lock b/Gemfile.lock index 3ac5d4b54..e9dac4fc7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -280,4 +280,4 @@ DEPENDENCIES yard-activesupport-concern BUNDLED WITH - 2.2.3 + 2.2.4 diff --git a/README.md b/README.md index d465000dd..b75331d40 100644 --- a/README.md +++ b/README.md @@ -234,6 +234,8 @@ GoodJob.on_thread_error = -> (exception) { Raven.capture_exception(exception) } ### Dashboard +![Dashboard UI](https://github.com/bensheldon/good_job/raw/main/SCREENSHOT.png) + _🚧 GoodJob's dashboard is a work in progress. Please contribute ideas and code on [Github](https://github.com/bensheldon/good_job/issues)._ GoodJob includes a Dashboard as a mountable `Rails::Engine`. diff --git a/SCREENSHOT.png b/SCREENSHOT.png new file mode 100644 index 000000000..bed2b3dac Binary files /dev/null and b/SCREENSHOT.png differ diff --git a/gemfiles/rails_5.2.gemfile.lock b/gemfiles/rails_5.2.gemfile.lock index 37c641d38..a51d35988 100644 --- a/gemfiles/rails_5.2.gemfile.lock +++ b/gemfiles/rails_5.2.gemfile.lock @@ -328,4 +328,4 @@ DEPENDENCIES yard-activesupport-concern BUNDLED WITH - 2.2.3 + 2.2.4 diff --git a/gemfiles/rails_6.0.gemfile.lock b/gemfiles/rails_6.0.gemfile.lock index bfe756fc5..6b47c26be 100644 --- a/gemfiles/rails_6.0.gemfile.lock +++ b/gemfiles/rails_6.0.gemfile.lock @@ -343,4 +343,4 @@ DEPENDENCIES yard-activesupport-concern BUNDLED WITH - 2.2.3 + 2.2.4 diff --git a/gemfiles/rails_6.1.gemfile.lock b/gemfiles/rails_6.1.gemfile.lock index 56bc94316..b35879ca9 100644 --- a/gemfiles/rails_6.1.gemfile.lock +++ b/gemfiles/rails_6.1.gemfile.lock @@ -345,4 +345,4 @@ DEPENDENCIES yard-activesupport-concern BUNDLED WITH - 2.2.3 + 2.2.4 diff --git a/gemfiles/rails_head.gemfile.lock b/gemfiles/rails_head.gemfile.lock index b6aeb68c8..504fadede 100644 --- a/gemfiles/rails_head.gemfile.lock +++ b/gemfiles/rails_head.gemfile.lock @@ -351,4 +351,4 @@ DEPENDENCIES yard-activesupport-concern BUNDLED WITH - 2.2.3 + 2.2.4 diff --git a/lib/good_job/configuration.rb b/lib/good_job/configuration.rb index 330ba5bda..545a02451 100644 --- a/lib/good_job/configuration.rb +++ b/lib/good_job/configuration.rb @@ -101,6 +101,9 @@ def poll_interval ).to_i end + # Number of seconds to preserve jobs when using the +good_job cleanup_preserved_jobs+ CLI command. + # This configuration is only used when {GoodJob.preserve_job_records} is +true+. + # @return [Boolean] def cleanup_preserved_jobs_before_seconds_ago ( options[:before_seconds_ago] || diff --git a/lib/good_job/notifier.rb b/lib/good_job/notifier.rb index 1adf98cec..ac65f61e5 100644 --- a/lib/good_job/notifier.rb +++ b/lib/good_job/notifier.rb @@ -9,6 +9,7 @@ module GoodJob # :nodoc: # When a message is received, the notifier passes the message to each of its recipients. # class Notifier + # Raised if the Database adapter does not implement LISTEN. AdapterCannotListenError = Class.new(StandardError) # Default Postgres channel for LISTEN/NOTIFY diff --git a/lib/good_job/poller.rb b/lib/good_job/poller.rb index e3eeaf877..fe1b97150 100644 --- a/lib/good_job/poller.rb +++ b/lib/good_job/poller.rb @@ -19,6 +19,9 @@ class Poller # @return [array] cattr_reader :instances, default: [], instance_reader: false + # Creates GoodJob::Poller from a GoodJob::Configuration instance. + # @param configuration [GoodJob::Configuration] + # @return [GoodJob::Poller] def self.from_configuration(configuration) GoodJob::Poller.new(poll_interval: configuration.poll_interval) end diff --git a/spec/test_app/db/schema.rb b/spec/test_app/db/schema.rb index 45b4f2d3c..d08e6213f 100644 --- a/spec/test_app/db/schema.rb +++ b/spec/test_app/db/schema.rb @@ -2,8 +2,8 @@ # of editing this file, please use the migrations feature of Active Record to # incrementally modify your database, and then regenerate this schema definition. # -# This file is the source Rails uses to define your schema when running `rails -# db:schema:load`. When creating a new database, `rails db:schema:load` tends to +# This file is the source Rails uses to define your schema when running `bin/rails +# db:schema:load`. When creating a new database, `bin/rails db:schema:load` tends to # be faster and is potentially less error prone than running all of your # migrations from scratch. Old migrations may fail to apply correctly if those # migrations use external dependencies or application code.