From 64f7fa8c8e9f5df87ef0b1ef337075b5af6ffc1d Mon Sep 17 00:00:00 2001 From: Ben Sheldon Date: Tue, 8 Dec 2020 11:05:06 -0800 Subject: [PATCH] Add linter gems to an ignorable gem group for compatibility with Ruby 2.5 --- .github/workflows/test.yml | 4 +- Gemfile | 9 +++++ gemfiles/rails_5.2.gemfile.lock | 64 -------------------------------- gemfiles/rails_6.0.gemfile.lock | 64 -------------------------------- gemfiles/rails_6.1.gemfile.lock | 59 ----------------------------- gemfiles/rails_head.gemfile.lock | 64 -------------------------------- good_job.gemspec | 6 --- 7 files changed, 11 insertions(+), 259 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8ec050850..512beac90 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -92,9 +92,9 @@ jobs: - name: Install bundler run: gem update --system && gem install bundler --default -v $(grep -A 1 "BUNDLED WITH" Gemfile.lock | tail -1 | tr -d " ") - name: Install Gemfile gems - run: bundle install + run: bundle install --without lint - name: Install Appraisal gems - run: bundle exec appraisal install --path $BUNDLE_PATH + run: bundle exec appraisal install --without lint --path $BUNDLE_PATH # /Dependencies - name: Set up test database diff --git a/Gemfile b/Gemfile index 62c034f97..38ea5ab6c 100644 --- a/Gemfile +++ b/Gemfile @@ -13,3 +13,12 @@ gemspec # To use a debugger # gem 'byebug', group: [:development, :test] +# +group :lint do + gem "erb_lint" + gem "mdl" + gem "rubocop" + gem "rubocop-performance" + gem "rubocop-rails" + gem "rubocop-rspec" +end diff --git a/gemfiles/rails_5.2.gemfile.lock b/gemfiles/rails_5.2.gemfile.lock index cc661803e..80503226d 100644 --- a/gemfiles/rails_5.2.gemfile.lock +++ b/gemfiles/rails_5.2.gemfile.lock @@ -61,15 +61,6 @@ GEM rake thor (>= 0.14.0) arel (9.0.0) - ast (2.4.1) - better_html (1.0.15) - actionview (>= 4.0) - activesupport (>= 4.0) - ast (~> 2.0) - erubi (~> 1.4) - html_tokenizer (~> 0.0.6) - parser (>= 2.4) - smart_properties builder (3.2.4) capybara (3.33.0) addressable @@ -79,7 +70,6 @@ GEM rack-test (>= 0.6.3) regexp_parser (~> 1.5) xpath (~> 3.2) - chef-utils (16.6.14) childprocess (3.0.0) coderay (1.1.3) concurrent-ruby (1.1.7) @@ -87,14 +77,6 @@ GEM database_cleaner (1.8.5) diff-lcs (1.4.4) dotenv (2.7.6) - erb_lint (0.0.35) - activesupport - better_html (~> 1.0.7) - html_tokenizer - parser (>= 2.7.1.4) - rainbow - rubocop (~> 0.79) - smart_properties erubi (1.10.0) faraday (1.1.0) multipart-post (>= 1.2, < 3) @@ -114,7 +96,6 @@ GEM retriable (~> 3.0) globalid (0.4.2) activesupport (>= 4.2.0) - html_tokenizer (0.0.7) i18n (1.8.5) concurrent-ruby (~> 1.0) kramdown (2.3.0) @@ -128,22 +109,11 @@ GEM mini_mime (>= 0.1.1) marcel (0.3.3) mimemagic (~> 0.3.2) - mdl (0.11.0) - kramdown (~> 2.3) - kramdown-parser-gfm (~> 1.1) - mixlib-cli (~> 2.1, >= 2.1.1) - mixlib-config (>= 2.2.1, < 4) - mixlib-shellout method_source (1.0.0) mimemagic (0.3.5) mini_mime (1.0.2) mini_portile2 (2.4.0) minitest (5.14.2) - mixlib-cli (2.1.8) - mixlib-config (3.0.9) - tomlrb - mixlib-shellout (3.1.6) - chef-utils msgpack (1.3.3) multi_json (1.15.0) multipart-post (2.1.1) @@ -154,9 +124,6 @@ GEM faraday (>= 0.9) sawyer (~> 0.8.0, >= 0.5.3) optimist (3.0.1) - parallel (1.19.2) - parser (2.7.2.0) - ast (~> 2.4.1) pg (1.2.3) pry (0.13.1) coderay (~> 1.1) @@ -219,28 +186,6 @@ GEM rspec-mocks (~> 3.9) rspec-support (~> 3.9) rspec-support (3.9.4) - rubocop (0.93.1) - parallel (~> 1.10) - parser (>= 2.7.1.5) - rainbow (>= 2.2.2, < 4.0) - regexp_parser (>= 1.8) - rexml - rubocop-ast (>= 0.6.0) - ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 2.0) - rubocop-ast (1.0.1) - parser (>= 2.7.1.5) - rubocop-performance (1.8.1) - rubocop (>= 0.87.0) - rubocop-ast (>= 0.4.0) - rubocop-rails (2.8.1) - activesupport (>= 4.2.0) - rack (>= 1.1) - rubocop (>= 0.87.0) - rubocop-rspec (1.44.1) - rubocop (~> 0.87) - rubocop-ast (>= 0.7.1) - ruby-progressbar (1.10.1) ruby2_keywords (0.0.2) rubyzip (2.3.0) sawyer (0.8.2) @@ -250,7 +195,6 @@ GEM childprocess (>= 0.5, < 4.0) rubyzip (>= 1.2.2) sigdump (0.2.4) - smart_properties (1.15.0) sprockets (4.0.2) concurrent-ruby (~> 1.0) rack (> 1, < 3) @@ -260,10 +204,8 @@ GEM sprockets (>= 3.0.0) thor (1.0.1) thread_safe (0.3.6) - tomlrb (1.3.0) tzinfo (1.2.8) thread_safe (~> 0.1) - unicode-display_width (1.7.0) websocket-driver (0.7.3) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) @@ -282,23 +224,17 @@ DEPENDENCIES capybara database_cleaner dotenv - erb_lint foreman gem-release github_changelog_generator good_job! kramdown kramdown-parser-gfm - mdl pry-rails puma rails (~> 5.2.0) rbtrace rspec-rails - rubocop - rubocop-performance - rubocop-rails - rubocop-rspec selenium-webdriver sigdump yard diff --git a/gemfiles/rails_6.0.gemfile.lock b/gemfiles/rails_6.0.gemfile.lock index 5b3624128..4da2fa0e8 100644 --- a/gemfiles/rails_6.0.gemfile.lock +++ b/gemfiles/rails_6.0.gemfile.lock @@ -74,15 +74,6 @@ GEM bundler rake thor (>= 0.14.0) - ast (2.4.1) - better_html (1.0.15) - actionview (>= 4.0) - activesupport (>= 4.0) - ast (~> 2.0) - erubi (~> 1.4) - html_tokenizer (~> 0.0.6) - parser (>= 2.4) - smart_properties builder (3.2.4) capybara (3.33.0) addressable @@ -92,7 +83,6 @@ GEM rack-test (>= 0.6.3) regexp_parser (~> 1.5) xpath (~> 3.2) - chef-utils (16.6.14) childprocess (3.0.0) coderay (1.1.3) concurrent-ruby (1.1.7) @@ -100,14 +90,6 @@ GEM database_cleaner (1.8.5) diff-lcs (1.4.4) dotenv (2.7.6) - erb_lint (0.0.35) - activesupport - better_html (~> 1.0.7) - html_tokenizer - parser (>= 2.7.1.4) - rainbow - rubocop (~> 0.79) - smart_properties erubi (1.10.0) faraday (1.1.0) multipart-post (>= 1.2, < 3) @@ -127,7 +109,6 @@ GEM retriable (~> 3.0) globalid (0.4.2) activesupport (>= 4.2.0) - html_tokenizer (0.0.7) i18n (1.8.5) concurrent-ruby (~> 1.0) kramdown (2.3.0) @@ -141,22 +122,11 @@ GEM mini_mime (>= 0.1.1) marcel (0.3.3) mimemagic (~> 0.3.2) - mdl (0.11.0) - kramdown (~> 2.3) - kramdown-parser-gfm (~> 1.1) - mixlib-cli (~> 2.1, >= 2.1.1) - mixlib-config (>= 2.2.1, < 4) - mixlib-shellout method_source (1.0.0) mimemagic (0.3.5) mini_mime (1.0.2) mini_portile2 (2.4.0) minitest (5.14.2) - mixlib-cli (2.1.8) - mixlib-config (3.0.9) - tomlrb - mixlib-shellout (3.1.6) - chef-utils msgpack (1.3.3) multi_json (1.15.0) multipart-post (2.1.1) @@ -167,9 +137,6 @@ GEM faraday (>= 0.9) sawyer (~> 0.8.0, >= 0.5.3) optimist (3.0.1) - parallel (1.19.2) - parser (2.7.2.0) - ast (~> 2.4.1) pg (1.2.3) pry (0.13.1) coderay (~> 1.1) @@ -234,28 +201,6 @@ GEM rspec-mocks (~> 3.9) rspec-support (~> 3.9) rspec-support (3.9.4) - rubocop (0.93.1) - parallel (~> 1.10) - parser (>= 2.7.1.5) - rainbow (>= 2.2.2, < 4.0) - regexp_parser (>= 1.8) - rexml - rubocop-ast (>= 0.6.0) - ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 2.0) - rubocop-ast (1.0.1) - parser (>= 2.7.1.5) - rubocop-performance (1.8.1) - rubocop (>= 0.87.0) - rubocop-ast (>= 0.4.0) - rubocop-rails (2.8.1) - activesupport (>= 4.2.0) - rack (>= 1.1) - rubocop (>= 0.87.0) - rubocop-rspec (1.44.1) - rubocop (~> 0.87) - rubocop-ast (>= 0.7.1) - ruby-progressbar (1.10.1) ruby2_keywords (0.0.2) rubyzip (2.3.0) sawyer (0.8.2) @@ -265,7 +210,6 @@ GEM childprocess (>= 0.5, < 4.0) rubyzip (>= 1.2.2) sigdump (0.2.4) - smart_properties (1.15.0) sprockets (4.0.2) concurrent-ruby (~> 1.0) rack (> 1, < 3) @@ -275,10 +219,8 @@ GEM sprockets (>= 3.0.0) thor (1.0.1) thread_safe (0.3.6) - tomlrb (1.3.0) tzinfo (1.2.8) thread_safe (~> 0.1) - unicode-display_width (1.7.0) websocket-driver (0.7.3) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) @@ -297,23 +239,17 @@ DEPENDENCIES capybara database_cleaner dotenv - erb_lint foreman gem-release github_changelog_generator good_job! kramdown kramdown-parser-gfm - mdl pry-rails puma rails (~> 6.0.0) rbtrace rspec-rails - rubocop - rubocop-performance - rubocop-rails - rubocop-rspec selenium-webdriver sigdump yard diff --git a/gemfiles/rails_6.1.gemfile.lock b/gemfiles/rails_6.1.gemfile.lock index e8b3fe7fb..d6d3f08f5 100644 --- a/gemfiles/rails_6.1.gemfile.lock +++ b/gemfiles/rails_6.1.gemfile.lock @@ -78,14 +78,6 @@ GEM bundler rake thor (>= 0.14.0) - ast (2.4.1) - better_html (0.0.12) - actionview (>= 4.0) - activesupport (>= 4.0) - erubi (~> 1.4) - html_tokenizer - parser (>= 2.4) - smart_properties builder (3.2.4) capybara (3.34.0) addressable @@ -95,7 +87,6 @@ GEM rack-test (>= 0.6.3) regexp_parser (~> 1.5) xpath (~> 3.2) - chef-utils (16.7.61) childprocess (3.0.0) coderay (1.1.3) concurrent-ruby (1.1.7) @@ -103,10 +94,6 @@ GEM database_cleaner (1.8.5) diff-lcs (1.4.4) dotenv (2.7.6) - erb_lint (0.0.9) - better_html (~> 0.0.10) - html_tokenizer - rubocop erubi (1.10.0) faraday (1.1.0) multipart-post (>= 1.2, < 3) @@ -126,7 +113,6 @@ GEM retriable (~> 3.0) globalid (0.4.2) activesupport (>= 4.2.0) - html_tokenizer (0.0.7) i18n (1.8.5) concurrent-ruby (~> 1.0) kramdown (2.3.0) @@ -140,22 +126,11 @@ GEM mini_mime (>= 0.1.1) marcel (0.3.3) mimemagic (~> 0.3.2) - mdl (0.11.0) - kramdown (~> 2.3) - kramdown-parser-gfm (~> 1.1) - mixlib-cli (~> 2.1, >= 2.1.1) - mixlib-config (>= 2.2.1, < 4) - mixlib-shellout method_source (1.0.0) mimemagic (0.3.5) mini_mime (1.0.2) mini_portile2 (2.4.0) minitest (5.14.2) - mixlib-cli (2.1.8) - mixlib-config (3.0.9) - tomlrb - mixlib-shellout (3.2.2) - chef-utils msgpack (1.3.3) multi_json (1.15.0) multipart-post (2.1.1) @@ -166,9 +141,6 @@ GEM faraday (>= 0.9) sawyer (~> 0.8.0, >= 0.5.3) optimist (3.0.1) - parallel (1.20.1) - parser (2.7.2.0) - ast (~> 2.4.1) pg (1.2.3) pry (0.13.1) coderay (~> 1.1) @@ -233,28 +205,6 @@ GEM rspec-mocks (~> 3.9) rspec-support (~> 3.9) rspec-support (3.10.0) - rubocop (1.5.2) - parallel (~> 1.10) - parser (>= 2.7.1.5) - rainbow (>= 2.2.2, < 4.0) - regexp_parser (>= 1.8, < 3.0) - rexml - rubocop-ast (>= 1.2.0, < 2.0) - ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 2.0) - rubocop-ast (1.3.0) - parser (>= 2.7.1.5) - rubocop-performance (1.9.1) - rubocop (>= 0.90.0, < 2.0) - rubocop-ast (>= 0.4.0) - rubocop-rails (2.9.0) - activesupport (>= 4.2.0) - rack (>= 1.1) - rubocop (>= 0.90.0, < 2.0) - rubocop-rspec (2.0.1) - rubocop (~> 1.0) - rubocop-ast (>= 1.1.0) - ruby-progressbar (1.10.1) ruby2_keywords (0.0.2) rubyzip (2.3.0) sawyer (0.8.2) @@ -264,7 +214,6 @@ GEM childprocess (>= 0.5, < 4.0) rubyzip (>= 1.2.2) sigdump (0.2.4) - smart_properties (1.15.0) sprockets (4.0.2) concurrent-ruby (~> 1.0) rack (> 1, < 3) @@ -273,10 +222,8 @@ GEM activesupport (>= 4.0) sprockets (>= 3.0.0) thor (1.0.1) - tomlrb (2.0.0) tzinfo (2.0.3) concurrent-ruby (~> 1.0) - unicode-display_width (1.7.0) websocket-driver (0.7.3) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) @@ -295,23 +242,17 @@ DEPENDENCIES capybara database_cleaner dotenv - erb_lint foreman gem-release github_changelog_generator good_job! kramdown kramdown-parser-gfm - mdl pry-rails puma rails (~> 6.1.pre.rc2) rbtrace rspec-rails - rubocop - rubocop-performance - rubocop-rails - rubocop-rspec selenium-webdriver sigdump yard diff --git a/gemfiles/rails_head.gemfile.lock b/gemfiles/rails_head.gemfile.lock index cb56f72cf..1317df231 100644 --- a/gemfiles/rails_head.gemfile.lock +++ b/gemfiles/rails_head.gemfile.lock @@ -105,15 +105,6 @@ GEM bundler rake thor (>= 0.14.0) - ast (2.4.1) - better_html (1.0.15) - actionview (>= 4.0) - activesupport (>= 4.0) - ast (~> 2.0) - erubi (~> 1.4) - html_tokenizer (~> 0.0.6) - parser (>= 2.4) - smart_properties builder (3.2.4) capybara (3.33.0) addressable @@ -123,7 +114,6 @@ GEM rack-test (>= 0.6.3) regexp_parser (~> 1.5) xpath (~> 3.2) - chef-utils (16.6.14) childprocess (3.0.0) coderay (1.1.3) concurrent-ruby (1.1.7) @@ -131,14 +121,6 @@ GEM database_cleaner (1.8.5) diff-lcs (1.4.4) dotenv (2.7.6) - erb_lint (0.0.35) - activesupport - better_html (~> 1.0.7) - html_tokenizer - parser (>= 2.7.1.4) - rainbow - rubocop (~> 0.79) - smart_properties erubi (1.10.0) faraday (1.1.0) multipart-post (>= 1.2, < 3) @@ -158,7 +140,6 @@ GEM retriable (~> 3.0) globalid (0.4.2) activesupport (>= 4.2.0) - html_tokenizer (0.0.7) i18n (1.8.5) concurrent-ruby (~> 1.0) kramdown (2.3.0) @@ -172,22 +153,11 @@ GEM mini_mime (>= 0.1.1) marcel (0.3.3) mimemagic (~> 0.3.2) - mdl (0.11.0) - kramdown (~> 2.3) - kramdown-parser-gfm (~> 1.1) - mixlib-cli (~> 2.1, >= 2.1.1) - mixlib-config (>= 2.2.1, < 4) - mixlib-shellout method_source (1.0.0) mimemagic (0.3.5) mini_mime (1.0.2) mini_portile2 (2.4.0) minitest (5.14.2) - mixlib-cli (2.1.8) - mixlib-config (3.0.9) - tomlrb - mixlib-shellout (3.1.6) - chef-utils msgpack (1.3.3) multi_json (1.15.0) multipart-post (2.1.1) @@ -198,9 +168,6 @@ GEM faraday (>= 0.9) sawyer (~> 0.8.0, >= 0.5.3) optimist (3.0.1) - parallel (1.19.2) - parser (2.7.2.0) - ast (~> 2.4.1) pg (1.2.3) pry (0.13.1) coderay (~> 1.1) @@ -244,28 +211,6 @@ GEM rspec-mocks (~> 3.9) rspec-support (~> 3.9) rspec-support (3.9.4) - rubocop (0.93.1) - parallel (~> 1.10) - parser (>= 2.7.1.5) - rainbow (>= 2.2.2, < 4.0) - regexp_parser (>= 1.8) - rexml - rubocop-ast (>= 0.6.0) - ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 2.0) - rubocop-ast (1.0.1) - parser (>= 2.7.1.5) - rubocop-performance (1.8.1) - rubocop (>= 0.87.0) - rubocop-ast (>= 0.4.0) - rubocop-rails (2.8.1) - activesupport (>= 4.2.0) - rack (>= 1.1) - rubocop (>= 0.87.0) - rubocop-rspec (1.44.1) - rubocop (~> 0.87) - rubocop-ast (>= 0.7.1) - ruby-progressbar (1.10.1) ruby2_keywords (0.0.2) rubyzip (2.3.0) sawyer (0.8.2) @@ -275,7 +220,6 @@ GEM childprocess (>= 0.5, < 4.0) rubyzip (>= 1.2.2) sigdump (0.2.4) - smart_properties (1.15.0) sprockets (4.0.2) concurrent-ruby (~> 1.0) rack (> 1, < 3) @@ -284,10 +228,8 @@ GEM activesupport (>= 4.0) sprockets (>= 3.0.0) thor (1.0.1) - tomlrb (1.3.0) tzinfo (2.0.3) concurrent-ruby (~> 1.0) - unicode-display_width (1.7.0) websocket-driver (0.7.3) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) @@ -306,23 +248,17 @@ DEPENDENCIES capybara database_cleaner dotenv - erb_lint foreman gem-release github_changelog_generator good_job! kramdown kramdown-parser-gfm - mdl pry-rails puma rails! rbtrace rspec-rails - rubocop - rubocop-performance - rubocop-rails - rubocop-rspec selenium-webdriver sigdump yard diff --git a/good_job.gemspec b/good_job.gemspec index 5f7ac13ac..455d94c53 100644 --- a/good_job.gemspec +++ b/good_job.gemspec @@ -59,22 +59,16 @@ Gem::Specification.new do |spec| spec.add_development_dependency "capybara" spec.add_development_dependency "database_cleaner" spec.add_development_dependency "dotenv" - spec.add_development_dependency "erb_lint" spec.add_development_dependency "foreman" spec.add_development_dependency "gem-release" spec.add_development_dependency "github_changelog_generator" spec.add_development_dependency "kramdown" spec.add_development_dependency "kramdown-parser-gfm" - spec.add_development_dependency "mdl" spec.add_development_dependency "pry-rails" spec.add_development_dependency "puma" spec.add_development_dependency "rails" spec.add_development_dependency "rbtrace" spec.add_development_dependency "rspec-rails" - spec.add_development_dependency "rubocop" - spec.add_development_dependency "rubocop-performance" - spec.add_development_dependency "rubocop-rails" - spec.add_development_dependency "rubocop-rspec" spec.add_development_dependency "selenium-webdriver" spec.add_development_dependency "sigdump" spec.add_development_dependency "yard"